diff options
| author | Cristián Maureira-Fredes <Cristian.Maureira-Fredes@qt.io> | 2023-08-01 18:56:06 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2023-08-02 13:19:30 +0000 |
| commit | 09b06281a63d481b7b90d8452ac1b361245c64c6 (patch) | |
| tree | 1ffe1670d8ecde95b1b62f8136d321b0484d5fea | |
| parent | 9c9ea35c40466e6b8c8c32c7c4c1926b0d36b40b (diff) | |
stubs: setParent should accept an Optional object
The current stubs specify the type of the required argument,
for example:
w = QWidget()
help(w.setParent)
reports:
setParent(self, parent: PySide6.QtWidgets.QWidget) -> None
which makes some IDEs to complain when passing None, behavior
that it's accepted as well.
This change adds an Optional to the parameter.
Fixes: PYSIDE-2235
Change-Id: I57b54f47aee6783b1b7027981b5d282798d57ad4
Reviewed-by: Christian Tismer <tismer@stackless.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
(cherry picked from commit 6280d50601705798d4fd96595b8c54fba436918f)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | sources/pyside6/PySide6/QtCore/typesystem_core_common.xml | 1 | ||||
| -rw-r--r-- | sources/pyside6/PySide6/QtWidgets/typesystem_widgets_common.xml | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml b/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml index b3b34922d..4ecd1a48d 100644 --- a/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml +++ b/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml @@ -1687,6 +1687,7 @@ <modify-argument index="this"> <parent index="1" action="add"/> </modify-argument> + <modify-argument index="1" pyi-type="Optional[PySide6.QtCore.QObject]"/> </modify-function> <modify-function signature="connect(const QObject*,const char*,const char*,Qt::ConnectionType)const"> <modify-argument index="4"> diff --git a/sources/pyside6/PySide6/QtWidgets/typesystem_widgets_common.xml b/sources/pyside6/PySide6/QtWidgets/typesystem_widgets_common.xml index cae565ba9..80230dc60 100644 --- a/sources/pyside6/PySide6/QtWidgets/typesystem_widgets_common.xml +++ b/sources/pyside6/PySide6/QtWidgets/typesystem_widgets_common.xml @@ -1977,12 +1977,14 @@ <modify-argument index="this"> <parent index="1" action="add"/> </modify-argument> + <modify-argument index="1" pyi-type="Optional[PySide6.QtWidgets.QWidget]"/> </modify-function> <modify-function signature="setParent(QWidget*,QFlags<Qt::WindowType>)"> <modify-argument index="this"> <parent index="1" action="add"/> </modify-argument> + <modify-argument index="1" pyi-type="Optional[PySide6.QtWidgets.QWidget]"/> </modify-function> <modify-function signature="parentWidget()const"> @@ -2243,6 +2245,7 @@ <modify-argument index="this"> <parent index="1" action="add"/> </modify-argument> + <modify-argument index="1" pyi-type="Optional[PySide6.QtWidgets.QWidget]"/> </modify-function> <modify-function signature="window()const"> |