From acfd71831cdea3f9177ee86ed1b5f7f9c7e2aa29 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Thu, 20 Oct 2022 22:47:02 +0200 Subject: Android: Fix crash in AndroidDeployQtStep info.cpuAbi in AndroidDeployQtStep::init can be empty, for example when opening a configured project with a different Qt Creator version, and the "No valid settings file could be found." message appears. Check for !empty(), before accessing the first item. Fixes: QTCREATORBUG-27795 Change-Id: Ife0bf495ed8ea7bfb342300ee2e457398c8ee8f2 Reviewed-by: hjk --- src/plugins/android/androiddeployqtstep.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/android/androiddeployqtstep.cpp b/src/plugins/android/androiddeployqtstep.cpp index beeb851118..e676c457c5 100644 --- a/src/plugins/android/androiddeployqtstep.cpp +++ b/src/plugins/android/androiddeployqtstep.cpp @@ -201,7 +201,8 @@ bool AndroidDeployQtStep::init() } const QtSupport::QtVersion * const qt = QtSupport::QtKitAspect::qtVersion(kit()); - if (qt && qt->supportsMultipleQtAbis() && !selectedAbis.contains(info.cpuAbi.first())) { + if (qt && qt->supportsMultipleQtAbis() && !info.cpuAbi.isEmpty() && + !selectedAbis.contains(info.cpuAbi.first())) { TaskHub::addTask(DeploymentTask(Task::Warning, tr("Android: The main ABI of the deployment device (%1) is not selected. The app " "execution or debugging might not work properly. Add it from Projects > Build > " -- cgit v1.2.3