From f0556b08b825ef92a3549f0581a441678a090fa1 Mon Sep 17 00:00:00 2001 From: Artem Sokolovskii Date: Mon, 19 Dec 2022 16:41:00 +0100 Subject: qmljs: Remove foreach usage Task-number: QTCREATORBUG-27464 Change-Id: Ifdb8cf514dfe328e0a64bde1beff3e63a4b7fbc3 Reviewed-by: Qt CI Bot Reviewed-by: hjk Reviewed-by: --- src/libs/qmljs/qmljsplugindumper.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src/libs/qmljs/qmljsplugindumper.cpp') diff --git a/src/libs/qmljs/qmljsplugindumper.cpp b/src/libs/qmljs/qmljsplugindumper.cpp index 882d3b8ef5..014de3974f 100644 --- a/src/libs/qmljs/qmljsplugindumper.cpp +++ b/src/libs/qmljs/qmljsplugindumper.cpp @@ -133,14 +133,15 @@ void PluginDumper::onLoadPluginTypes(const Utils::FilePath &libraryPath, } // add typeinfo files listed in qmldir - foreach (const QString &typeInfo, libraryInfo.typeInfos()) { + for (const QString &typeInfo : libraryInfo.typeInfos()) { const FilePath pathNow = canonicalLibraryPath.resolvePath(typeInfo); if (!plugin.typeInfoPaths.contains(pathNow) && pathNow.exists()) plugin.typeInfoPaths += pathNow; } // watch plugin libraries - foreach (const QmlDirParser::Plugin &plugin, snapshot.libraryInfo(canonicalLibraryPath).plugins()) { + const QList plugins = snapshot.libraryInfo(canonicalLibraryPath).plugins(); + for (const QmlDirParser::Plugin &plugin : plugins) { const QString pluginLibrary = resolvePlugin(canonicalLibraryPath.toString(), plugin.path, plugin.name); if (!pluginLibrary.isEmpty()) { if (!pluginWatcher()->watchesFile(pluginLibrary)) @@ -165,7 +166,7 @@ void PluginDumper::onLoadPluginTypes(const Utils::FilePath &libraryPath, void PluginDumper::dumpAllPlugins() { - foreach (const Plugin &plugin, m_plugins) { + for (const Plugin &plugin : std::as_const(m_plugins)) { dump(plugin); } } @@ -676,7 +677,7 @@ QString PluginDumper::resolvePlugin(const QDir &qmldirPath, const QString &qmldi if (!qmldirPluginPathIsRelative) searchPaths.prepend(qmldirPluginPath); - foreach (const QString &pluginPath, searchPaths) { + for (const QString &pluginPath : std::as_const(searchPaths)) { QString resolvedPath; @@ -690,7 +691,7 @@ QString PluginDumper::resolvePlugin(const QDir &qmldirPath, const QString &qmldi } QDir dir(resolvedPath); - foreach (const QString &suffix, suffixes) { + for (const QString &suffix : suffixes) { QString pluginFileName = prefix; pluginFileName += baseName; -- cgit v1.2.3