From d4565be6557fca844dcf4bf427e0ff9c0838df50 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 12 Mar 2019 16:50:39 +0100 Subject: ProjectExplorer: Drop KitAspect::defaultValue() The functionality of this function overlapped with KitAspect::setup(), leading to unclear responsibilities and resulting in bugs such as the one fixed by 776d54e435. Therefore, we drop the defaultValue() function, merging its implementation with setup() where applicable. Change-Id: Iefa9c3df8b76e97ddf9ad388516621f7ea6558d4 Reviewed-by: hjk --- src/plugins/projectexplorer/kit.cpp | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/plugins/projectexplorer/kit.cpp') diff --git a/src/plugins/projectexplorer/kit.cpp b/src/plugins/projectexplorer/kit.cpp index cc0ca3a39f..ddc4d00c7c 100644 --- a/src/plugins/projectexplorer/kit.cpp +++ b/src/plugins/projectexplorer/kit.cpp @@ -137,8 +137,6 @@ public: Kit::Kit(Id id) : d(std::make_unique(id, this)) { - for (KitAspect *aspect : KitManager::kitAspects()) - d->m_data.insert(aspect->id(), aspect->defaultValue(this)); } Kit::Kit(const QVariantMap &data) : -- cgit v1.2.3