From d8c1feb99547c3b2b6ba63b2783330ef94a61ce3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pasi=20Pet=C3=A4j=C3=A4j=C3=A4rvi?= Date: Tue, 20 Jun 2023 15:30:08 +0300 Subject: Print sensible information when compared test result is zero We cannot calculate percentage improvement from zero, so instead print message stating this with test result it's being compared. Change-Id: Icea838931782fa661ddec505f5dd2ce1377e5a51 Reviewed-by: Eskil Abrahamsen Blomfeldt --- tools/compareresults/main.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/compareresults/main.cpp b/tools/compareresults/main.cpp index c387be7..94d25c0 100644 --- a/tools/compareresults/main.cpp +++ b/tools/compareresults/main.cpp @@ -156,7 +156,9 @@ int main(int argc, char **argv) const double differenceInPercent = (newValue - oldValue) * 100 / oldValue; - if (differenceInPercent > 0) { + if (differenceInPercent == INFINITY) { + printf("Reference testrun result for %s was zero. New result is %.f\n", qPrintable(testName), newValue); + } else if (differenceInPercent > 0) { printf("%s: improvement by %.2f%%\n", qPrintable(testName), differenceInPercent); } else if (differenceInPercent < 0) { printf("%s: regression by %.2f%%\n", qPrintable(testName), differenceInPercent); -- cgit v1.2.3