summaryrefslogtreecommitdiffstats
path: root/src/plugins
Commit message (Collapse)AuthorAgeFilesLines
...
* Changed Qt release version to 4.8.4jutaipal2012-10-081-1/+1
| | | | | | | Change-Id: I45f7894f7e79617b6ccb8caa464bbbffaf9dd7b5 Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com> Reviewed-by: Akseli Salovaara <akseli.salovaara@digia.com> Reviewed-by: Lars Knoll <lars.knoll@digia.com>
* QNX: Only set parent window if it is not NULLRafael Roquetto2012-10-021-1/+1
| | | | | | | | | | | | | | | There are cases where a widget has a parent, but is also a toplevel window at the same time, causing the system window to have no parent. For instance, a QMenu usually has a QMenuBar as a parent, however QMenuBar itself does not have its own platform window, as opposed to QMenu. Thus QMenuBar::parent == QMainWindow (for example), but QMenuBar::platformWindow == 0x0; QMenu::parent == QMenuBar, but QMenu::platformWindow != 0x0 (which is QMenuBar's value). cherry-picked from qt5 04d296d64118ba2d647668494872d93cc1ef7ed1 Change-Id: I9304c5c9e64dca012a1903de7c80c168a701a5ea Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com>
* QNX: Fix bug on window hierarchy listThomas McGuire2012-10-021-8/+6
| | | | | | | | | | | | removeFromParent() must not be called from raise()/lower(), because it wrongly sets m_currentParent to 0, causing the parent/child link to be broken after a call either of these methods. This is a backport of qtbase commit 4c33efc3228d82a82e13fe8c196b8c74a4998572 Change-Id: I5970cd2b2e0d58ef01dd99c10748195220d0e006 Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Blackberry: Support input method hintsThomas McGuire2012-10-023-4/+23
| | | | | | | | This is a backport of qtbase commit d162f276714f04b07827dfd525deea45dc55a5f1 Change-Id: I3ae3994d305eebd61773e175332cecfa1d9cde51 Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Blackberry: Fix hardware button detection on the BB Dev AlphaThomas McGuire2012-10-021-1/+1
| | | | | | | | | | | The format of the PPS object has changed, it is now prefixed with [n], so be more leninent in parsing to support both formats. This is a backport of qtbase commit fda3fac1d276952ddac4f5a916339db1940082d5 Change-Id: Ibb9b2bef150ca184e2bb234e55e04975552f10b1 Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* QNX: use assert on QBBWindow destructorRafael Roquetto2012-09-301-5/+3
| | | | | | | | | | | This makes it clear that the mChildren size must be 0 at this point, indicating otherwise an inconsistency in the logic of the child windows management. cherry-picked from qt5 72d7a833bd6cd2074f45c1ea32986d498b6dd476 Change-Id: I7c0eb9b1b1121b708badb46bd423de0e75d206a6 Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* Fix g++/MinGW compiler warnings.Friedemann Kleint2012-09-293-4/+4
| | | | | | | | | | - Assigned/Unused variables. - Unsigned comparison >= 0 is always true. - Constructor initialization order. - Signed/Unsigned comparisons. Change-Id: I1f9edab0506573420ed0bf3055252ba48625c8eb Reviewed-by: Kai Koehne <kai.koehne@digia.com>
* Change copyrights from Nokia to DigiaIikka Eklund2012-09-29524-12364/+12548
| | | | | | | | Change copyrights and license headers from Nokia to Digia Change-Id: I280c0a575987d1770e354b4948f1d4d767d711ea Reviewed-by: Simo Fält <simo.falt@digia.com> Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
* QNX: don't show the virtual keyboard when focusing an item view.Nicolas Arnaud-Cormos2012-09-251-1/+5
| | | | | | | | | This patch is not needed in Qt5, as it works as expected. Change-Id: I3d165c3f5b8562207af20a0564c3884270d17b44 Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Nicolas Arnaud-Cormos <nicolas@kdab.com>
* Rotate non maximized windowsRafael Roquetto2012-09-212-0/+109
| | | | | | | | | | | | | | | | | There are two types of rotation to be considered: 1. Rotation of native widgets The corresponding window should be rotated and resized proportionally to the new screen geometry. 2. Rotation of toplevel windows. The window will be only rotated. It will be only moved or resized if it becomes clipped, in order to be fitted on the screen properly. cherry-picked from qt5 89d9f8fe949e65e7455fabe288ea284aa6de06b1 Change-Id: I837da53f1a12a7b8aff1e0e9d6f4579e3aefaf2a Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com>
* QNX: Enable support for hardware buttons in QPA pluginSean Harmer2012-09-175-4/+321
| | | | | | | Backport of 3f407cddf8b1d5fc09b414dbecd9a47d30e3abe7 Change-Id: Id7fd3ca76793d8d3e3698dd402fe31e04567e938 Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* qpa: improve DirectFB performanceJulien Brianceau2012-09-131-0/+4
| | | | | | | | | | QDirectFbWindowSurface::resize() must call parent QWindowSurface::resize() method in order to update QWindowSurfacePrivate size. Change-Id: Icd605dc1923f2560579ccb2e4f800c80ff7e92fd Reviewed-by: Holger Freyther <holger+qt@freyther.de> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
* Fixed crash in blackberry platform plugin shutdownBernd Weimer2012-09-121-3/+3
| | | | | | | | Change-Id: I6f83b1223b7bd57b5dfc46fe5bed276269b1a676 Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com> Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* qpa: extend drawPixmap capabilitiesJulien Brianceau2012-09-122-33/+48
| | | | | | | | | | Extend drawPixmap capabilities for qpa through new OpacityPixmapCapability QBlittable flag and add related implementation in DirectFB platform. cherry-picked from qt5/qtbase 4ae829c1dbd0e8a72b82ab4c6cddb0a4ffe009f6 Change-Id: I8abdb0fa72bc030d769190d7cba40561007e7b46 Reviewed-by: Jørgen Lind <jorgen.lind@gmail.com>
* qpa: add non-opaque fill supportJulien Brianceau2012-09-122-12/+54
| | | | | | | | | | | Add non-opaque fill support for qpa through new QBlittable flag "AlphaFillRectCapability" and add related implementation in DirectFB qpa platform. cherry-picked from qt5/qtbase aab15782e21bf0aaea7f2211278e9aa9fc78c6d7 Change-Id: Ia1c74c2926d2e244290dcb62cbd3b6848ba95707 Reviewed-by: Jørgen Lind <jorgen.lind@nokia.com>
* Fix calculation of logical child index for row headers.Tilman Sauerbeck2012-09-071-1/+1
| | | | | | Change-Id: I6b7a5b4d698d496a6710dd479b24f10c7d7e5851 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com> Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Backport fix screen event-registration failure.James Turner2012-08-311-0/+13
| | | | | | | | | | Don't attempt to register for events from non-attached screens. Backport of commit 9597e0d2a23c4673aea7a74598a6a634527c443c from qt5/qtbase Change-Id: I95859abc476f43308ba9b2c684b8eaae731c59f6 Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Implementation of the BlackBerry Bearer engineBenoit Dumas2012-08-305-0/+644
| | | | | | | | | | | An implementation for BlackBerry devices based on the BPS netstatus APIs. cherry-picked from qtbase df7a1a28aaab31 Change-Id: I979f594aca64315af1f39e68886b819f7f215f6b Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com> Reviewed-by: Vladimir Minenko <vminenko@rim.com> Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Make QStatusBar text available via accessibility.Tilman Sauerbeck2012-08-232-1/+6
| | | | | Change-Id: Iec3efb4b91bdba33fe93b928ff2349440e15aa35 Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* uikit: update screen geometry correctly for interface orientationEike Ziller2012-08-231-7/+6
| | | | | | | Broke with baeb42184402454da3e337bbfa2f4d5c7346435f Change-Id: Ia8d844b7b4b9815a1cce4a1acccdbe515149d3ea Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
* uikit: Fix missing point to pixel conversionsEike Ziller2012-08-231-6/+6
| | | | | | | Qt wants drag distance and font size in pixels. Change-Id: I363ed9ab8bcfdcddbfd168fc81b71c4184ecfa5c Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
* uikit: Adapt readme and examples to recent changesEike Ziller2012-08-233-24/+17
| | | | | | | | | Use the new configure option (4720003c8f52ad7ecb59be04e1b5aa319c2f0ff0) Add info about mkspecs (c13df9f2147e85e104ac105f975ef87914c908e9) Change-Id: I4eadd4807a36400de3cf261605e3e1a71d217bbc Reviewed-by: Ian Dean <ian@mediator-software.com> Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
* Implement QAccessibleLineEdit::characterRect()Jan-Arve Saether2012-08-161-3/+16
| | | | | | | | | It was probably not implemented because it needed to access private APIs. However, accessing those from this a11y plugin is unproblematic. Change-Id: Icadad45a83daa60e2fbc4cab17b91c84c3f36a7f Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
* license: Fix Blackberry/QNX license headersSergio Ahumada2012-08-1446-186/+94
| | | | | | | | | | | | | These files where skipped when tst_license was enabled a while ago since they had a different license header that didn't match our test. Fix these licenses and stop skipping them in tst_license.cpp Change-Id: I14b2aa1b7c794894c2c74aedab01ff8667621003 Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com> Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Accessibility: Add missing break;Jan-Arve Saether2012-08-141-0/+1
| | | | | | | Found while porting QAccessibleTextWidget to Qt 5 Change-Id: I6a8f69d859fad20949e8250f03dd18d4106cc31c Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
* Changed qt version to 4.8.3jutaipal2012-08-081-1/+1
| | | | | | | | | Change-Id: Ib26f4c1d3b236f947d685ef5c376c203bda0e650 Reviewed-by: Lars Knoll <lars.knoll@nokia.com> Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com> Reviewed-by: Akseli Salovaara <akseli.salovaara@digia.com> Reviewed-by: Simo Fält <simo.falt@nokia.com> Reviewed-by: Juha Kukkonen <ext-juha.kukkonen@nokia.com>
* Update contact information in license headers.Sergio Ahumada2012-08-01473-946/+946
| | | | | | | | | | | | | - Replace Nokia contact email address with Qt Project website. - Remove "All rights reserved" line from license headers. As in the past, to avoid rewriting various autotests that contain line-number information, an extra blank line has been inserted at the end of the license text to ensure that this commit does not change the total number of lines in the license header. Change-Id: Ie7ba62011752fcb149b99b26317c54f2a0cfa931 Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
* Accessibility: fix updates for models with rootIndex set.Frederik Gladhorn2012-07-301-6/+12
| | | | | | | | | The accessible table/list implementation would ignore when a root index is set, resulting in trying to use row/column for the top level index, leading to accessing invalid indexes. Change-Id: I2568522053bafe48458446dd2f47b68d98d634aa Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
* Fix duplicate mouse event being sent for LinuxInput touch eventsRomain Pokrzywka2012-07-301-1/+1
| | | | | | | | | | | | | | This is due to the X and Y messages being received before the TOUCH one, followed by a SYNC message which then creates the second mouseEvent. The event should actually be sent on the SYNC message, so remove the one sent from the TOUCH message handler, just set the posChanged flag. For more details see: http://www.kernel.org/doc/Documentation/input/event-codes.txt Change-Id: I30e71fc3e7da24d8e698467b4d6e0bcd5a64eb37 Reviewed-by: Paul Olav Tvete <paul.tvete@nokia.com> Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
* Remove QtDeclarative dependency from UIKit plugin.Ian Dean2012-07-251-4/+5
| | | | | | Change-Id: I8425b98ecb908b1b912385c3ed2acb9df4b47f2d Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com> Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
* Moved CoreText (iOS) font database to shared font database plugin folder.Ian Dean2012-07-254-11/+13
| | | | | | Change-Id: I780e5b12159c078356334f5225f878ec525a8a64 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com> Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
* Removed existing iOS mkspecs. Added Qt5 iOS mkspecs to unsupported.Ian Dean2012-07-252-2/+20
| | | | | Change-Id: I504d987abd092d25c68f7209cb5787a01d6fac50 Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
* [Blackberry] Initialize dangling pointerRafael Roquetto2012-07-171-0/+1
| | | | | | | | | | | | This was causing the plugin to misbehave whenever the pointer was pointing to random memory address. This is a Qt4 only issue. Change-Id: Ibfe5eec52414b8c37d613b3a99f310ed1184c4ea Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* Support fallbacks fonts in UIKit pluginEskil Abrahamsen Blomfeldt2012-07-163-17/+115
| | | | | | | | Code is taken from the Qt 5 CoreText font database, but the hardcoded path for the plist has been modified for iOS. Change-Id: I71271600ec5dd085d469d5c42f9811a23948021f Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
* Blackberry: Apply state from QWidget when creating new QBBWindowThomas McGuire2012-07-161-0/+7
| | | | | | | | | | | Otherwise things like the window position and the parent/child relation were wrong. This is a backport from qtbase commit 095f2d5292ddfb4c77056af89c11327d85af282b. Change-Id: I838a15def49c004d0a0229f208ffa8e4f7aa5216 Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Support high resolution screens in QUIKit pluginEskil Abrahamsen Blomfeldt2012-07-132-2/+13
| | | | | | | | | We need to duplicate the scale factor of the screen for the UIView to avoid the final blit to scale the framebuffer, and we need to report scaled metrics to Qt. Change-Id: I79f9a06708436e70e8e7f632f2248b70813214f9 Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
* Disable dedicated screen event thread by default.Rafael Roquetto2012-07-071-3/+3
| | | | | | | | | | Screen events should come through QEventDispatcherBlackberry by default. cherry-picked from qt5/qtbase c54ba8c2520243217e2901fa4379f50ccde0be96 Change-Id: I230a334da1341aca5d6b439298994e630c719233 Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com>
* QNX: Flush after changing rotationThomas McGuire2012-06-281-0/+4
| | | | | | | | | | | This fixes a painting glitch where the window would stay in the old position with the old rotation until it got repainted. This is a backport of commit c196f89b7e298252944680bf0ba230a33feef718 from qtbase. Change-Id: Idbbcd706befef0aadb3f79ab412b41f487ae978b Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Enable MT screen event handling on BlackberryRafael Roquetto2012-06-263-12/+38
| | | | | | | | | | | | | | | | | | Consuming incoming screen events through the BPS event dispatcher on its current incarnation has proven to be very inefficient since it cannot put up with the screen event throughput. This patch enables the screen event thread also for Q_OS_BLACKBERRY platforms, in addition to stock QNX. This behavior can still be configurated through the project file, though. Task-number: QTBUG-26177 akin to qt5/qtbase: 9e66ee2d59d28d61e06e5c57485f1a331b82f269 Change-Id: I307b805f125d0eb213b21b3ef4476c4df5d6a853 Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
* Fix virtual keyboard setHeight() for BlackberryPeter Hansen2012-06-192-2/+2
| | | | | | | | | | Applies to Qt 4.8 only. Task-number: QTBUG-26160 Change-Id: I4a110ade1f817cc5d9a866e57e1d710abd83d143 Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* [Blackberry] Fix deletion of dangling pointersRafael Roquetto2012-06-191-1/+2
| | | | | | | | | | | This bug affects only Qt 4.8 series. Task-number: QTBUG-25796 Change-Id: I42c9bf5e8778e9bac2bb10c8e5888e02a61f72d7 Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> Reviewed-by: Andreas Holzammer <andreas.holzammer@kdab.com>
* DirectFB: Improvement for QDirectFBPaintEngine::fill()Marcel Schuette2012-05-301-12/+9
| | | | | | | | | | | | | | | | | | | Improvement for bug fix related to QTBUG-23850 in QDirectFBPaintEngine: combine the conditions for an accelerated fillrect (5 elements and rectangle shape) in first if-statement. The previous check for NULL pointer solves the problem for the crash, but it simply skips the type check (which caused the crash before) and the or-condition (shape) became true and leads to an accelerated fillrect. Otherwise it would fallback to raster. The original reason for the crash (elemets is null) might be Q_DISABLE_COPY macro of QVectorPath, especially with the last lines of the Q_DISABLE_COPY documentation, which could become true on embedded devices, where DirectFB is often used, with special toolchains/compilers. Task-number: QTBUG-23850 Change-Id: I340291fbce24260c7522684305c292e66cfc32af Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
* QNX: Special case z-ordering of the QDesktopWidget windowSean Harmer2012-05-211-1/+11
| | | | | | | | | | | | | | | | | The assumption that window creation order implies correct initial z-ordering is broken when dealing with certain window types. In this commit we special case the QDesktopWidget's window which maybe created after normal application windows yet still need to be layered below them. Without this fix we may accidentaly activate the Desktop window when the blackberry navigator service sends an event to activate the window group. That results in broken focus handling. Backport of b09d601261244395450557187adeed6717f25155 (qtbase) Change-Id: If7c4b1ac9d99dc5a9b7d0e7b3e2080c648cf85b3 Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* Advertise window (de)activation to Qt event systemKevin Ottens2012-05-103-0/+34
| | | | | | | | | | | | | The integration plugin now connects screens to the newly introduced signals of the navigator event handler. The relevant screen then push a corresponding event to the Qt event loop. (This is a backport from qtbase commit b6a4d69830c0d188b4f6c424808390dd8e3a90bc) Change-Id: I28c8843f2aea75bc685dcfd6e005bc628bc69202 Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* Emit signals to notify window (de)activationKevin Ottens2012-05-104-0/+46
| | | | | | | | | | | | | The event notifier now deals also with the windowActive and windowInactive PPS messages. The event handler simply emit the corresponding signals. (This is a backport from qtbase commit f74e5a03598e102a1d81eb4fca58e41db713e5dc) Change-Id: If9ae70d132e6a38a2dd728d8eba31dfd144e9978 Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* Windows 7 - fix nativewifi bearer pluginShane Kearns2012-05-092-7/+21
| | | | | | | | | | | The plugin code only handled the 2 events from windows XP, while there are more events defined on vista/7. As the scan complete event was being ignored, updates did not complete. Task-number: QTBUG-24503 Change-Id: Ib1fd6883b0fd6962f61dab7830e577b9292163ef Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com> (cherry picked from commit b45f0418e34a73da1729376c540b312b14b8ffda)
* Add implementation of virtual keyboard based on BPS eventsKevin Krammer2012-05-038-43/+339
| | | | | | | | Backport of a818a1eb2f3d2c5ac61da7e1a8cf1b341e63aed1 Change-Id: I32bc78eb465890702cbf657b077fdf1f8e8e4a63 Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
* Handle navigator events in BPS event filterKevin Krammer2012-05-033-4/+81
| | | | | | | | Backport of 050ff2730c96831aedb5897a60eafaf13ae8d93e Change-Id: Ida0566e88d5f53ea879a7fd2bda6746814b4e365 Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
* Register for and handle screen events delivered through BPSKevin Krammer2012-05-038-52/+100
| | | | | | | | | | | | Delegates actual event inspection and reaction to the screen event handler class already used by the PPS screen event handler Backport of e212d25972dbc19e3cc687b8c7bd4503eec8a602 Change-Id: I0e7f2fb91bedd0b5200d90b9e67be55ec9386dde Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com> Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
* Use BPS based event handlingKevin Krammer2012-05-035-2/+192
| | | | | | | | | | | | | | | | Create a QPA specific subclass of the blackberry event dispatcher (basically the BPS equivalent to QPAEventDispatcherGlib or QEventDispatcherQPA. Create an event dispatcher event filter that will receive all BPS events and then either handle them itself or delegate to event subtype specific handlers. Backport of fa94f01489611f2c72d1678b4d9439a584e7c4f9 Change-Id: Ie51c064c5ef1faca04e09a4f7ff35069ff6afda5 Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com> Reviewed-by: Sean Harmer <sean.harmer@kdab.com> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>