From 36b6183bdf414a1363692c8f86e023ea305dcfba Mon Sep 17 00:00:00 2001 From: Wieland Hagen Date: Wed, 4 May 2016 18:59:09 +0200 Subject: Eliminate references to dead memory Buffer data upload from QML would not copy the buffer data from the JS buffer class, but just store a pointer to it. JS Garbage collection may free that memory while it is still used by QBuffer Task-number: QTBUG-51667 Change-Id: I366e4e8ad601f058ae022ec4b4978e18eed0e395 Reviewed-by: Sean Harmer --- src/quick3d/quick3drender/items/quick3dbuffer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/quick3d/quick3drender/items') diff --git a/src/quick3d/quick3drender/items/quick3dbuffer.cpp b/src/quick3d/quick3drender/items/quick3dbuffer.cpp index 1371dd5cb..70753d6ab 100644 --- a/src/quick3d/quick3drender/items/quick3dbuffer.cpp +++ b/src/quick3d/quick3drender/items/quick3dbuffer.cpp @@ -71,7 +71,7 @@ QByteArray Quick3DBuffer::convertToRawData(const QJSValue &jsValue) char *dataPtr = reinterpret_cast(typedArray->arrayData()->data()); dataPtr += typedArray->d()->byteOffset; uint byteLength = typedArray->byteLength(); - return QByteArray::fromRawData(dataPtr, byteLength); + return QByteArray(dataPtr, byteLength); } QVariant Quick3DBuffer::bufferData() const -- cgit v1.2.3