diff options
author | Simon Hausmann <simon.hausmann@theqtcompany.com> | 2015-04-10 14:56:24 +0200 |
---|---|---|
committer | Simon Hausmann <simon.hausmann@theqtcompany.com> | 2015-04-16 17:14:15 +0000 |
commit | 496ddbfd1fe27bdddf5c15cd0ea70df452a3ec04 (patch) | |
tree | 779aece69688317cf41c2e5757a7d8684054cc52 /src/qml/qml/qqmlcontextwrapper.cpp | |
parent | d22db9e458828d403110fa0b9de1ca0c831d7e96 (diff) |
Speed up object creation with lots of id name objects
In the common case when objects are referenced by id, we don't need the
QQmlContextData's property name cache for the lookup. Instead of bindings
we resolve the id to an integer at type compilation time. Therefore we can
delay the population of the QQmlContextData's propertyNames until we need it
and therefore safe time on startup.
Change-Id: I2e8eeb51b1ac92f230059be3467f9a1e00fdbbef
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Diffstat (limited to 'src/qml/qml/qqmlcontextwrapper.cpp')
-rw-r--r-- | src/qml/qml/qqmlcontextwrapper.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/qml/qml/qqmlcontextwrapper.cpp b/src/qml/qml/qqmlcontextwrapper.cpp index 2498e5acc9..7aca9ad6c2 100644 --- a/src/qml/qml/qqmlcontextwrapper.cpp +++ b/src/qml/qml/qqmlcontextwrapper.cpp @@ -199,8 +199,9 @@ ReturnedValue QmlContextWrapper::get(Managed *m, String *name, bool *hasProperty while (context) { // Search context properties - if (context->propertyNames.count()) { - int propertyIdx = context->propertyNames.value(name); + const QV4::IdentifierHash<int> &properties = context->propertyNames(); + if (properties.count()) { + int propertyIdx = properties.value(name); if (propertyIdx != -1) { @@ -308,8 +309,9 @@ void QmlContextWrapper::put(Managed *m, String *name, const Value &value) QObject *scopeObject = wrapper->getScopeObject(); while (context) { + const QV4::IdentifierHash<int> &properties = context->propertyNames(); // Search context properties - if (context->propertyNames.count() && -1 != context->propertyNames.value(name)) + if (properties.count() && properties.value(name) != -1) return; // Search scope object |