summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2017-04-01 23:09:34 -0700
committerThiago Macieira <thiago.macieira@intel.com>2017-04-04 06:31:05 +0000
commitd22bd4cf4f3a6b106f357574f0c2c076c98e6ae7 (patch)
treeaf4f26cee1795b0e536f6fc649528bda162ebb41
parent92efbd613a7f1aa3f8b0f54beeb2ae77ca98812a (diff)
Fix warning about using a non-literal in qWarning
And in the process, fix the encoding. Since this can be translated, it's not restricted to US-ASCII. qhelpsearchindexwriter_default.cpp:79:18: warning: format string is not a string literal (potentially insecure) [-Wformat-security] Change-Id: I27b55fdf514247549455fffd14b17fb6da0617d0 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
-rw-r--r--src/assistant/help/qhelpsearchindexwriter_default.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/assistant/help/qhelpsearchindexwriter_default.cpp b/src/assistant/help/qhelpsearchindexwriter_default.cpp
index ccb97f06c..1bd518c97 100644
--- a/src/assistant/help/qhelpsearchindexwriter_default.cpp
+++ b/src/assistant/help/qhelpsearchindexwriter_default.cpp
@@ -76,7 +76,7 @@ Writer::Writer(const QString &path)
if (!m_db->open()) {
const QString error = QHelpSearchIndexWriter::tr("Cannot open database \"%1\" using connection \"%2\": %3")
.arg(dbPath, m_uniqueId, m_db->lastError().text());
- qWarning(qPrintable(error));
+ qWarning("%s", qUtf8Printable(error));
delete m_db;
m_db = nullptr;
QSqlDatabase::removeDatabase(m_uniqueId);