diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-06-20 10:28:27 +0200 |
|---|---|---|
| committer | Alexandru Croitor <alexandru.croitor@qt.io> | 2017-07-07 09:15:45 +0000 |
| commit | 7976efd28ca37c12a4d65f992deff9bc573f3008 (patch) | |
| tree | d0960cf8420d30497dd0b8ffcbebb978caf64525 | |
| parent | 41c20711637fa1d117ece075dd6833bc9685b6af (diff) | |
[Backport] Fix for CVE-2017-5083
Merge "Form validation: Do not show validation bubble during printing." to M59.
It was possible to show it in media query listener.
BUG=714849
Review-Url: https://codereview.chromium.org/2845273002
Merge "Forms: Validation Message bubble should not open during print()." to M59.
r467941 was a wrong approach because ShouldUsePrintingLayout() returns false
before closing print-preview dialog. We should check Page::Suspended() instead.
BUG=714849
Change-Id: Ide6c987378e381c8254aacddd3aae011636475cb
Review-Url: https://codereview.chromium.org/2866193002
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| -rw-r--r-- | chromium/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chromium/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/chromium/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp index d870d812191..2930cc15a31 100644 --- a/chromium/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp +++ b/chromium/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp @@ -485,6 +485,8 @@ void HTMLFormControlElement::updateVisibleValidationMessage() Page* page = document().page(); if (!page || page->visibilityState() != PageVisibilityStateVisible) return; + if (page->suspended()) + return; String message; if (layoutObject() && willValidate()) message = validationMessage().stripWhiteSpace(); |