diff options
| author | Shubham Sandeep Rastogi <srastogi22@apple.com> | 2024-01-05 12:13:36 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-05 12:13:36 -0800 |
| commit | f22dc88759a53d4224c17d3833a359ef5674b4ea (patch) | |
| tree | 4bb2832519ef20931156a076f7567f6857e7f262 | |
| parent | f9aba820eb6478a617145eb690ba8b06490d7ac5 (diff) | |
[NFC] Address review feedback from PR #77004 (#77134)
Accidentally didn't commit the review feedback before merging the PR
| -rw-r--r-- | llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp | 4 | ||||
| -rw-r--r-- | llvm/test/tools/llvm-dwarfdump/verify-no-file.yaml | 5 |
2 files changed, 4 insertions, 5 deletions
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp b/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp index 18377815c78b..d25b732fdba3 100644 --- a/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp +++ b/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp @@ -944,8 +944,8 @@ void DWARFVerifier::verifyDebugLineRows() { // row, do not verify the file index, this is a line table of an empty // file with an end_sequence, but the DWARF standard sets the file number // to 1 by default, otherwise verify file index. - if (!(LineTable->Prologue.FileNames.size() == 0 && - LineTable->Rows.size() == 1) && + if ((LineTable->Prologue.FileNames.size() || + LineTable->Rows.size() != 1) && !LineTable->hasFileAtIndex(Row.File)) { ++NumDebugLineErrors; error() << ".debug_line[" diff --git a/llvm/test/tools/llvm-dwarfdump/verify-no-file.yaml b/llvm/test/tools/llvm-dwarfdump/verify-no-file.yaml index e43bb8808216..fc25fceef764 100644 --- a/llvm/test/tools/llvm-dwarfdump/verify-no-file.yaml +++ b/llvm/test/tools/llvm-dwarfdump/verify-no-file.yaml @@ -1,6 +1,5 @@ -# RUN: rm -rf %t && mkdir -p %t -# RUN: yaml2obj %s -o %t/test.o -# RUN: llvm-dwarfdump --debug-line --verify %t/test.o 2>&1 | FileCheck %s +# RUN: yaml2obj %s -o %t.o +# RUN: llvm-dwarfdump --debug-line --verify %t.o 2>&1 | FileCheck %s # CHECK-NOT: error: .debug_line[0x{{[0-9a-f]+}}][0] has invalid file index 1 (valid values are [1,0]): --- !mach-o |