diff options
| author | Kuba Mracek <mracek@apple.com> | 2017-08-15 20:29:24 +0000 |
|---|---|---|
| committer | Kuba Mracek <mracek@apple.com> | 2017-08-15 20:29:24 +0000 |
| commit | 17ee427ef35d7521f90f28a7db83fddb4aadd475 (patch) | |
| tree | 0d63ef2fcb684b5fbddf5e45cca3acfded4af8b6 /llvm/test/Other/lit-globbing.ll | |
| parent | cea6267cc6114bc3ee89e66ede36239841d813c0 (diff) | |
[llvm] Get rid of "%T" expansions
The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests. In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban %T and only keep %t, which is unique to each test. When a test needs a temporary directory, it can just create one using mkdir %t.
This patch removes %T in llvm.
Differential Revision: https://reviews.llvm.org/D36495
llvm-svn: 310953
Diffstat (limited to 'llvm/test/Other/lit-globbing.ll')
| -rw-r--r-- | llvm/test/Other/lit-globbing.ll | 33 |
1 files changed, 17 insertions, 16 deletions
diff --git a/llvm/test/Other/lit-globbing.ll b/llvm/test/Other/lit-globbing.ll index 5a668a90a40b..3b3a647af180 100644 --- a/llvm/test/Other/lit-globbing.ll +++ b/llvm/test/Other/lit-globbing.ll @@ -1,19 +1,20 @@ -RUN: echo TA > %T/TA.txt
-RUN: echo TB > %T/TB.txt
-RUN: echo TAB > %T/TAB.txt
-
-RUN: echo %T/TA* | FileCheck -check-prefix=STAR %s
-RUN: echo %T/'TA'* | FileCheck -check-prefix=STAR %s
-RUN: echo %T/T'A'* | FileCheck -check-prefix=STAR %s
-
-RUN: echo %T/T?.txt | FileCheck -check-prefix=QUESTION %s
-RUN: echo %T/'T'?.txt | FileCheck -check-prefix=QUESTION %s
-
-RUN: echo %T/T??.txt | FileCheck -check-prefix=QUESTION2 %s
-RUN: echo %T/'T'??.txt | FileCheck -check-prefix=QUESTION2 %s
-
-RUN: echo 'T*' 'T?.txt' 'T??.txt' | FileCheck -check-prefix=QUOTEDARGS %s
-
+RUN: rm -rf %t && mkdir -p %t +RUN: echo TA > %t/TA.txt +RUN: echo TB > %t/TB.txt +RUN: echo TAB > %t/TAB.txt + +RUN: echo %t/TA* | FileCheck -check-prefix=STAR %s +RUN: echo %t/'TA'* | FileCheck -check-prefix=STAR %s +RUN: echo %t/T'A'* | FileCheck -check-prefix=STAR %s + +RUN: echo %t/T?.txt | FileCheck -check-prefix=QUESTION %s +RUN: echo %t/'T'?.txt | FileCheck -check-prefix=QUESTION %s + +RUN: echo %t/T??.txt | FileCheck -check-prefix=QUESTION2 %s +RUN: echo %t/'T'??.txt | FileCheck -check-prefix=QUESTION2 %s + +RUN: echo 'T*' 'T?.txt' 'T??.txt' | FileCheck -check-prefix=QUOTEDARGS %s + STAR-NOT: TB.txt
STAR: {{(TA.txt.*TAB.txt|TAB.txt.*TA.txt)}}
|