From 930d99948f3e2266e7093b0c85eaa0ff38218202 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Wed, 12 Oct 2011 08:53:21 +0200 Subject: Multimedia: Compile on Windows. MSVC is more strict about #include <> and #include "". Reviewed-by: Ling Hu Change-Id: I8973d7b2717d892407ad93785f92a64b05bdb6b5 Reviewed-on: http://codereview.qt-project.org/6134 Sanity-Review: Qt Sanity Bot Reviewed-by: Friedemann Kleint --- src/imports/multimedia/qdeclarativecamera_p.h | 13 +++++++------ src/imports/multimedia/qdeclarativecameracapture_p.h | 2 ++ src/imports/multimedia/qdeclarativecameraexposure_p.h | 2 +- src/multimedia/qcamera.cpp | 8 ++++---- src/multimedia/qcameraexposure.cpp | 10 +++++----- src/multimedia/qcamerafocus.cpp | 8 ++++---- src/multimedia/qcameraimagecapture.cpp | 2 +- src/multimedia/qcameraimageprocessing.cpp | 8 ++++---- src/multimedia/qmediaimageviewer.cpp | 2 +- src/multimedia/qmediaimageviewerservice.cpp | 2 +- src/multimedia/qmediaplayer.cpp | 18 +++++++++--------- src/multimedia/qmediaplaylistsourcecontrol.cpp | 4 ++-- src/multimedia/qmediarecorder.cpp | 2 +- src/multimedia/qmetadatareadercontrol.cpp | 2 +- src/multimedia/qmetadatawritercontrol.cpp | 2 +- src/multimediawidgets/qcameraviewfinder.cpp | 10 +++++----- src/multimediawidgets/qcameraviewfinder.h | 2 +- src/multimediawidgets/qgraphicsvideoitem.cpp | 5 ++--- src/multimediawidgets/qgraphicsvideoitem.h | 2 +- src/multimediawidgets/qpaintervideosurface.cpp | 4 ++-- src/multimediawidgets/qtmultimediawidgetdefs.h | 2 +- src/multimediawidgets/qvideowidget.cpp | 2 +- src/multimediawidgets/qvideowidget.h | 2 +- src/multimediawidgets/qvideowidgetcontrol.h | 2 +- src/multimediawidgets/qvideowindowcontrol.h | 2 +- 25 files changed, 60 insertions(+), 58 deletions(-) diff --git a/src/imports/multimedia/qdeclarativecamera_p.h b/src/imports/multimedia/qdeclarativecamera_p.h index a96dd6e..7004f7e 100644 --- a/src/imports/multimedia/qdeclarativecamera_p.h +++ b/src/imports/multimedia/qdeclarativecamera_p.h @@ -53,16 +53,17 @@ // We mean it. // -#include -#include -#include -#include +#include "qdeclarativecameracapture_p.h" +#include "qdeclarativecamerarecorder_p.h" #include #include #include -#include -#include + +#include +#include +#include +#include QT_BEGIN_HEADER diff --git a/src/imports/multimedia/qdeclarativecameracapture_p.h b/src/imports/multimedia/qdeclarativecameracapture_p.h index ec464a0..6effa74 100644 --- a/src/imports/multimedia/qdeclarativecameracapture_p.h +++ b/src/imports/multimedia/qdeclarativecameracapture_p.h @@ -57,6 +57,8 @@ #include #include +#include + QT_BEGIN_HEADER QT_BEGIN_NAMESPACE diff --git a/src/imports/multimedia/qdeclarativecameraexposure_p.h b/src/imports/multimedia/qdeclarativecameraexposure_p.h index d4411ad..677d963 100644 --- a/src/imports/multimedia/qdeclarativecameraexposure_p.h +++ b/src/imports/multimedia/qdeclarativecameraexposure_p.h @@ -53,9 +53,9 @@ // We mean it. // +#include "qdeclarativecamera_p.h" #include #include -#include QT_BEGIN_HEADER diff --git a/src/multimedia/qcamera.cpp b/src/multimedia/qcamera.cpp index 2b18726..fd1fe5b 100644 --- a/src/multimedia/qcamera.cpp +++ b/src/multimedia/qcamera.cpp @@ -39,11 +39,10 @@ ** ****************************************************************************/ -#include +#include "qvideosurfaceoutput_p.h" +#include "qmediaobject_p.h" #include - -#include #include #include #include @@ -52,7 +51,8 @@ #include #include #include -#include + +#include QT_USE_NAMESPACE diff --git a/src/multimedia/qcameraexposure.cpp b/src/multimedia/qcameraexposure.cpp index 580b1ca..5c75ad9 100644 --- a/src/multimedia/qcameraexposure.cpp +++ b/src/multimedia/qcameraexposure.cpp @@ -39,15 +39,15 @@ ** ****************************************************************************/ -#include +#include "qcameraexposure.h" +#include "qmediaobject_p.h" -#include #include - -#include #include #include -#include + +#include +#include QT_BEGIN_NAMESPACE diff --git a/src/multimedia/qcamerafocus.cpp b/src/multimedia/qcamerafocus.cpp index 22a0bbc..9b9caed 100644 --- a/src/multimedia/qcamerafocus.cpp +++ b/src/multimedia/qcamerafocus.cpp @@ -39,12 +39,10 @@ ** ****************************************************************************/ -#include +#include "qcamerafocus.h" +#include "qmediaobject_p.h" #include -#include - -#include #include #include #include @@ -52,6 +50,8 @@ #include #include +#include + QT_BEGIN_NAMESPACE namespace diff --git a/src/multimedia/qcameraimagecapture.cpp b/src/multimedia/qcameraimagecapture.cpp index 6b399b6..f49531e 100644 --- a/src/multimedia/qcameraimagecapture.cpp +++ b/src/multimedia/qcameraimagecapture.cpp @@ -45,7 +45,7 @@ #include #include -#include +#include "qmediaobject_p.h" #include #include #include diff --git a/src/multimedia/qcameraimageprocessing.cpp b/src/multimedia/qcameraimageprocessing.cpp index 600dfd8..4286afc 100644 --- a/src/multimedia/qcameraimageprocessing.cpp +++ b/src/multimedia/qcameraimageprocessing.cpp @@ -39,11 +39,9 @@ ** ****************************************************************************/ -#include +#include "qcameraimageprocessing.h" +#include "qmediaobject_p.h" -#include - -#include #include #include #include @@ -52,6 +50,8 @@ #include #include +#include + QT_BEGIN_NAMESPACE /*! diff --git a/src/multimedia/qmediaimageviewer.cpp b/src/multimedia/qmediaimageviewer.cpp index 01265dc..9a9a656 100644 --- a/src/multimedia/qmediaimageviewer.cpp +++ b/src/multimedia/qmediaimageviewer.cpp @@ -48,7 +48,7 @@ #include #include #include -#include +#include "qvideosurfaceoutput_p.h" #include #include diff --git a/src/multimedia/qmediaimageviewerservice.cpp b/src/multimedia/qmediaimageviewerservice.cpp index 65de7a8..94c6d2e 100644 --- a/src/multimedia/qmediaimageviewerservice.cpp +++ b/src/multimedia/qmediaimageviewerservice.cpp @@ -46,7 +46,7 @@ #include #include -#include +#include "qmediaobject_p.h" #include #include diff --git a/src/multimedia/qmediaplayer.cpp b/src/multimedia/qmediaplayer.cpp index 5d5a7a7..312122d 100644 --- a/src/multimedia/qmediaplayer.cpp +++ b/src/multimedia/qmediaplayer.cpp @@ -39,25 +39,25 @@ ** ****************************************************************************/ -#include -#include -#include -#include -#include - - #include "qmediaplayer.h" +#include "qvideosurfaceoutput_p.h" -#include +#include "qmediaobject_p.h" #include #include #include #include #include #include -#include + #include +#include +#include +#include +#include +#include + QT_BEGIN_NAMESPACE /*! diff --git a/src/multimedia/qmediaplaylistsourcecontrol.cpp b/src/multimedia/qmediaplaylistsourcecontrol.cpp index ca90fed..2ab8aee 100644 --- a/src/multimedia/qmediaplaylistsourcecontrol.cpp +++ b/src/multimedia/qmediaplaylistsourcecontrol.cpp @@ -40,8 +40,8 @@ ****************************************************************************/ -#include -#include +#include "qmediaplaylistsourcecontrol.h" +#include "qmediacontrol_p.h" QT_BEGIN_NAMESPACE diff --git a/src/multimedia/qmediarecorder.cpp b/src/multimedia/qmediarecorder.cpp index bcbae57..6be462d 100644 --- a/src/multimedia/qmediarecorder.cpp +++ b/src/multimedia/qmediarecorder.cpp @@ -42,7 +42,7 @@ #include "qmediarecorder.h" #include -#include +#include "qmediaobject_p.h" #include #include #include diff --git a/src/multimedia/qmetadatareadercontrol.cpp b/src/multimedia/qmetadatareadercontrol.cpp index a15cf6d..63dd375 100644 --- a/src/multimedia/qmetadatareadercontrol.cpp +++ b/src/multimedia/qmetadatareadercontrol.cpp @@ -39,7 +39,7 @@ ** ****************************************************************************/ -#include +#include "qmediacontrol_p.h" #include QT_BEGIN_NAMESPACE diff --git a/src/multimedia/qmetadatawritercontrol.cpp b/src/multimedia/qmetadatawritercontrol.cpp index 0888bcf..9d01662 100644 --- a/src/multimedia/qmetadatawritercontrol.cpp +++ b/src/multimedia/qmetadatawritercontrol.cpp @@ -39,7 +39,7 @@ ** ****************************************************************************/ -#include +#include "qmediacontrol_p.h" #include QT_BEGIN_NAMESPACE diff --git a/src/multimediawidgets/qcameraviewfinder.cpp b/src/multimediawidgets/qcameraviewfinder.cpp index 1d3f185..91a9083 100644 --- a/src/multimediawidgets/qcameraviewfinder.cpp +++ b/src/multimediawidgets/qcameraviewfinder.cpp @@ -39,14 +39,14 @@ ** ****************************************************************************/ -#include - -#include +#include "qcameraviewfinder.h" +#include "qvideowidget_p.h" #include -#include -#include #include +#include + +#include QT_USE_NAMESPACE diff --git a/src/multimediawidgets/qcameraviewfinder.h b/src/multimediawidgets/qcameraviewfinder.h index 4ac39eb..f1ab3f2 100644 --- a/src/multimediawidgets/qcameraviewfinder.h +++ b/src/multimediawidgets/qcameraviewfinder.h @@ -65,7 +65,7 @@ QT_MODULE(Multimedia) class QCamera; class QCameraViewfinderPrivate; -class Q_MULTIMEDIA_EXPORT QCameraViewfinder : public QVideoWidget +class Q_MULTIMEDIAWIDGETS_EXPORT QCameraViewfinder : public QVideoWidget { Q_OBJECT public: diff --git a/src/multimediawidgets/qgraphicsvideoitem.cpp b/src/multimediawidgets/qgraphicsvideoitem.cpp index 120a24f..c92fb1e 100644 --- a/src/multimediawidgets/qgraphicsvideoitem.cpp +++ b/src/multimediawidgets/qgraphicsvideoitem.cpp @@ -40,17 +40,16 @@ ****************************************************************************/ #include "qgraphicsvideoitem.h" +#include "qpaintervideosurface_p.h" #include #include -#include #include +#include #include #include -#include - #if !defined(QT_NO_OPENGL) && !defined(QT_OPENGL_ES_1_CL) && !defined(QT_OPENGL_ES_1) #include #endif diff --git a/src/multimediawidgets/qgraphicsvideoitem.h b/src/multimediawidgets/qgraphicsvideoitem.h index cf89134..c92d42d 100644 --- a/src/multimediawidgets/qgraphicsvideoitem.h +++ b/src/multimediawidgets/qgraphicsvideoitem.h @@ -59,7 +59,7 @@ QT_END_NAMESPACE QT_BEGIN_NAMESPACE class QGraphicsVideoItemPrivate; -class Q_MULTIMEDIA_EXPORT QGraphicsVideoItem : public QGraphicsObject, public QMediaBindableInterface +class Q_MULTIMEDIAWIDGETS_EXPORT QGraphicsVideoItem : public QGraphicsObject, public QMediaBindableInterface { Q_OBJECT Q_INTERFACES(QMediaBindableInterface) diff --git a/src/multimediawidgets/qpaintervideosurface.cpp b/src/multimediawidgets/qpaintervideosurface.cpp index bd82f78..8c31dd5 100644 --- a/src/multimediawidgets/qpaintervideosurface.cpp +++ b/src/multimediawidgets/qpaintervideosurface.cpp @@ -39,8 +39,8 @@ ** ****************************************************************************/ -#include -#include +#include "qpaintervideosurface_p.h" +#include "qpaintervideosurface_mac_p.h" #include diff --git a/src/multimediawidgets/qtmultimediawidgetdefs.h b/src/multimediawidgets/qtmultimediawidgetdefs.h index 57ce226..0816d47 100644 --- a/src/multimediawidgets/qtmultimediawidgetdefs.h +++ b/src/multimediawidgets/qtmultimediawidgetdefs.h @@ -65,7 +65,7 @@ QT_BEGIN_HEADER # if defined(QT_DLL) # undef QT_DLL # endif -# if defined(QT_BUILD_MULTIMEDIA_LIB) +# if defined(QT_BUILD_MULTIMEDIAWIDGETS_LIB) # define Q_MULTIMEDIAWIDGETS_EXPORT Q_DECL_EXPORT # else # define Q_MULTIMEDIAWIDGETS_EXPORT Q_DECL_IMPORT diff --git a/src/multimediawidgets/qvideowidget.cpp b/src/multimediawidgets/qvideowidget.cpp index f31144c..919ed1f 100644 --- a/src/multimediawidgets/qvideowidget.cpp +++ b/src/multimediawidgets/qvideowidget.cpp @@ -40,13 +40,13 @@ ****************************************************************************/ #include "qvideowidget_p.h" +#include "qpaintervideosurface_p.h" #include #include #include #include -#include #include #include #include diff --git a/src/multimediawidgets/qvideowidget.h b/src/multimediawidgets/qvideowidget.h index c4c6f8d..b9d2cfe 100644 --- a/src/multimediawidgets/qvideowidget.h +++ b/src/multimediawidgets/qvideowidget.h @@ -57,7 +57,7 @@ QT_MODULE(Multimedia) class QMediaObject; class QVideoWidgetPrivate; -class Q_MULTIMEDIA_EXPORT QVideoWidget : public QWidget, public QMediaBindableInterface +class Q_MULTIMEDIAWIDGETS_EXPORT QVideoWidget : public QWidget, public QMediaBindableInterface { Q_OBJECT Q_INTERFACES(QMediaBindableInterface) diff --git a/src/multimediawidgets/qvideowidgetcontrol.h b/src/multimediawidgets/qvideowidgetcontrol.h index c5ac880..41a02dd 100644 --- a/src/multimediawidgets/qvideowidgetcontrol.h +++ b/src/multimediawidgets/qvideowidgetcontrol.h @@ -56,7 +56,7 @@ QT_MODULE(Multimedia) class QVideoWidgetControlPrivate; -class Q_MULTIMEDIA_EXPORT QVideoWidgetControl : public QMediaControl +class Q_MULTIMEDIAWIDGETS_EXPORT QVideoWidgetControl : public QMediaControl { Q_OBJECT diff --git a/src/multimediawidgets/qvideowindowcontrol.h b/src/multimediawidgets/qvideowindowcontrol.h index 590ce64..f8e1c63 100644 --- a/src/multimediawidgets/qvideowindowcontrol.h +++ b/src/multimediawidgets/qvideowindowcontrol.h @@ -54,7 +54,7 @@ QT_BEGIN_NAMESPACE QT_MODULE(Multimedia) -class Q_MULTIMEDIA_EXPORT QVideoWindowControl : public QMediaControl +class Q_MULTIMEDIAWIDGETS_EXPORT QVideoWindowControl : public QMediaControl { Q_OBJECT -- cgit v1.2.3