diff options
author | Jonas Toth <jonas.toth@gmail.com> | 2019-01-10 11:56:44 +0000 |
---|---|---|
committer | Jonas Toth <jonas.toth@gmail.com> | 2019-01-10 11:56:44 +0000 |
commit | b6a07261c461a738f1bdbd5eba3450badfc60d77 (patch) | |
tree | 6c879e2961bbc9251408ad0c38f121eeca673810 | |
parent | 797199bfeb6c2bc24521d6bdd489266b1e6d80e5 (diff) |
[clang-tidy] Fix case of local variables in modernize-use-nodiscard checker
Summary:
Correct the case of the local variables..
Rational:
I want to be able to run clang-tidy on new clang-tidy checker code prior to creating a review (to demonstrate we should dog food our own tools during development, not my suggestion but @Eugene.Zelenko)
To this end I am running the following in a script, prior to make a change.
```
tidy:
@for source in $$(git status -suno | grep ".cpp$$" | cut -c4-) ;\
do \
clang-tidy -quiet $$source -- $(TIDY_FLAGS);\
done
```
I then want to go through the checkers and see which checkers most closely match the review style of the reviewers
```
---
Checks: '
-clang-diagnostic-*,
readability-identifier-naming,
llvm-header-guard
'
WarningsAsErrors: ''
HeaderFilterRegex: ''
AnalyzeTemporaryDtors: false
FormatStyle: LLVM
CheckOptions:
- key: readability-identifier-naming.IgnoreFailedSplit
value: '0'
- key: readability-identifier-naming.VariableCase
value: 'CamelCase'
- key: readability-identifier-naming.LocalVariableCase
value: 'CamelCase'
...
```
Unfortunately in doing so, I have identified that my previous review {D55433} it violates what looks like to be the convention of local variables being in CamelCase.
Sending this small review in the hope it can be corrected.
Patch by MyDeveloperDay.
Reviewers: JonasToth, Eugene.Zelenko
Reviewed By: JonasToth
Subscribers: xazax.hun, Eugene.Zelenko
Differential Revision: https://reviews.llvm.org/D56536
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@350814 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | clang-tidy/modernize/UseNodiscardCheck.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/clang-tidy/modernize/UseNodiscardCheck.cpp b/clang-tidy/modernize/UseNodiscardCheck.cpp index 69e17340..f655515b 100644 --- a/clang-tidy/modernize/UseNodiscardCheck.cpp +++ b/clang-tidy/modernize/UseNodiscardCheck.cpp @@ -92,7 +92,7 @@ void UseNodiscardCheck::registerMatchers(MatchFinder *Finder) { !getLangOpts().CPlusPlus) return; - auto functionObj = + auto FunctionObj = cxxRecordDecl(hasAnyName("::std::function", "::boost::function")); // Find all non-void const methods which have not already been marked to @@ -107,8 +107,8 @@ void UseNodiscardCheck::registerMatchers(MatchFinder *Finder) { hasAttr(clang::attr::WarnUnusedResult), hasType(isInstantiationDependentType()), hasAnyParameter(anyOf( - parmVarDecl(anyOf(hasType(functionObj), - hasType(references(functionObj)))), + parmVarDecl(anyOf(hasType(FunctionObj), + hasType(references(FunctionObj)))), hasType(isNonConstReferenceOrPointer()), hasParameterPack())))))) .bind("no_discard"), @@ -122,11 +122,11 @@ void UseNodiscardCheck::check(const MatchFinder::MatchResult &Result) { if (Loc.isInvalid() || Loc.isMacroID()) return; - SourceLocation retLoc = MatchedDecl->getInnerLocStart(); + SourceLocation RetLoc = MatchedDecl->getInnerLocStart(); ASTContext &Context = *Result.Context; - auto Diag = diag(retLoc, "function %0 should be marked " + NoDiscardMacro) + auto Diag = diag(RetLoc, "function %0 should be marked " + NoDiscardMacro) << MatchedDecl; // Check for the existence of the keyword being used as the ``[[nodiscard]]``. @@ -137,7 +137,7 @@ void UseNodiscardCheck::check(const MatchFinder::MatchResult &Result) { // 1. A const member function which returns a variable which is ignored // but performs some external I/O operation and the return value could be // ignored. - Diag << FixItHint::CreateInsertion(retLoc, NoDiscardMacro + " "); + Diag << FixItHint::CreateInsertion(RetLoc, NoDiscardMacro + " "); } } // namespace modernize |