diff options
author | Kirill Bobyrev <kbobyrev.opensource@gmail.com> | 2018-07-26 14:00:00 +0000 |
---|---|---|
committer | Kirill Bobyrev <kbobyrev.opensource@gmail.com> | 2018-07-26 14:00:00 +0000 |
commit | 87a923505dcd22cab47c085d545e88b7207bd02e (patch) | |
tree | 985b778a41d46f9101e84534c211e2ee5e312c68 | |
parent | a92c9ad17aed52e9c0656578213e35a6546d09a7 (diff) |
[clangd] Fix unit tests for Dex
Iterators took temporary objects in constructors, objects were
invalidated when built with recent Clang which resulted in crashes.
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@338028 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | unittests/clangd/DexIndexTests.cpp | 27 |
1 files changed, 20 insertions, 7 deletions
diff --git a/unittests/clangd/DexIndexTests.cpp b/unittests/clangd/DexIndexTests.cpp index 755cd768..c3be710f 100644 --- a/unittests/clangd/DexIndexTests.cpp +++ b/unittests/clangd/DexIndexTests.cpp @@ -24,7 +24,8 @@ namespace dex { using ::testing::ElementsAre; TEST(DexIndexIterators, DocumentIterator) { - auto DocIterator = create({4, 7, 8, 20, 42, 100}); + const PostingList L = {4, 7, 8, 20, 42, 100}; + auto DocIterator = create(L); EXPECT_EQ(DocIterator->peek(), 4U); EXPECT_EQ(DocIterator->reachedEnd(), false); @@ -194,12 +195,18 @@ TEST(DexIndexIterators, QueryTree) { // |1, 3, 5, 8, 9| |1, 5, 7, 9| |Empty| |0, 5| |0, 1, 5| // +-------------+ +----------+ +-----+ +----+ +-------+ + const PostingList L0 = {1, 3, 5, 8, 9}; + const PostingList L1 = {1, 5, 7, 9}; + const PostingList L2 = {0, 5}; + const PostingList L3 = {0, 1, 5}; + const PostingList L4; + // Root of the query tree: [1, 5] auto Root = createAnd({ // Lower And Iterator: [1, 5, 9] - createAnd({create({1, 3, 5, 8, 9}), create({1, 5, 7, 9})}), + createAnd({create(L0), create(L1)}), // Lower Or Iterator: [0, 1, 5] - createOr({create({0, 5}), create({0, 1, 5}), create({})}), + createOr({create(L2), create(L3), create(L4)}), }); EXPECT_EQ(Root->reachedEnd(), false); @@ -218,12 +225,18 @@ TEST(DexIndexIterators, QueryTree) { } TEST(DexIndexIterators, StringRepresentation) { - EXPECT_EQ(llvm::to_string(*(create({4, 7, 8, 20, 42, 100}))), - "[4, 7, 8, 20, 42, 100]"); + const PostingList L0 = {4, 7, 8, 20, 42, 100}; + const PostingList L1 = {1, 3, 5, 8, 9}; + const PostingList L2 = {1, 5, 7, 9}; + const PostingList L3 = {0, 5}; + const PostingList L4 = {0, 1, 5}; + const PostingList L5; + + EXPECT_EQ(llvm::to_string(*(create(L0))), "[4, 7, 8, 20, 42, 100]"); auto Nested = createAnd({ - createAnd({create({1, 3, 5, 8, 9}), create({1, 5, 7, 9})}), - createOr({create({0, 5}), create({0, 1, 5}), create({})}), + createAnd({create(L1), create(L2)}), + createOr({create(L3), create(L4), create(L5)}), }); EXPECT_EQ(llvm::to_string(*Nested), |