diff options
| author | Sam McCall <sam.mccall@gmail.com> | 2017-11-23 17:12:04 +0000 |
|---|---|---|
| committer | Sam McCall <sam.mccall@gmail.com> | 2017-11-23 17:12:04 +0000 |
| commit | b8acc957e750319f8a1cfa40c92167ac8f262975 (patch) | |
| tree | 849c93c082f89059f5342902f3a80fbe334a55ca /unittests | |
| parent | 5c83fea4dc025b0fcbddffadd478d14253d52815 (diff) | |
[clangd] Tracing improvements
Summary:
[clangd] Tracing improvements
Compose JSON using JSONExpr
Allow attaching metadata to spans (and avoid it if tracing is off)
Attach IDs and responses of JSON RPCs to their spans
The downside is that large responses make the trace viewer sluggish.
We should make our responses less huge :-) Or fix trace viewer.
Reviewers: ilya-biryukov
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D40132
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@318928 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests')
| -rw-r--r-- | unittests/clangd/TraceTests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/unittests/clangd/TraceTests.cpp b/unittests/clangd/TraceTests.cpp index cfda638e..48ea8c11 100644 --- a/unittests/clangd/TraceTests.cpp +++ b/unittests/clangd/TraceTests.cpp @@ -116,7 +116,7 @@ TEST(TraceTest, SmokeTest) { ASSERT_NE(++Event, Events->end()) << "Expected span start"; EXPECT_TRUE(VerifyObject(*Event, {{"ph", "B"}, {"name", "A"}})); ASSERT_NE(++Event, Events->end()) << "Expected log message"; - EXPECT_TRUE(VerifyObject(*Event, {{"ph", "i"}, {"name", "B"}})); + EXPECT_TRUE(VerifyObject(*Event, {{"ph", "i"}, {"name", "Log"}})); ASSERT_NE(++Event, Events->end()) << "Expected span end"; EXPECT_TRUE(VerifyObject(*Event, {{"ph", "E"}})); ASSERT_EQ(++Event, Events->end()); |