diff options
Diffstat (limited to 'clang-tidy/abseil/TimeComparisonCheck.cpp')
-rw-r--r-- | clang-tidy/abseil/TimeComparisonCheck.cpp | 61 |
1 files changed, 61 insertions, 0 deletions
diff --git a/clang-tidy/abseil/TimeComparisonCheck.cpp b/clang-tidy/abseil/TimeComparisonCheck.cpp new file mode 100644 index 00000000..391f38f1 --- /dev/null +++ b/clang-tidy/abseil/TimeComparisonCheck.cpp @@ -0,0 +1,61 @@ +//===--- TimeComparisonCheck.cpp - clang-tidy +//--------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "TimeComparisonCheck.h" +#include "DurationRewriter.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Tooling/FixIt.h" + +using namespace clang::ast_matchers; + +namespace clang { +namespace tidy { +namespace abseil { + +void TimeComparisonCheck::registerMatchers(MatchFinder *Finder) { + auto Matcher = + expr(comparisonOperatorWithCallee(functionDecl( + functionDecl(TimeConversionFunction()).bind("function_decl")))) + .bind("binop"); + + Finder->addMatcher(Matcher, this); +} + +void TimeComparisonCheck::check(const MatchFinder::MatchResult &Result) { + const auto *Binop = Result.Nodes.getNodeAs<BinaryOperator>("binop"); + + llvm::Optional<DurationScale> Scale = getScaleForTimeInverse( + Result.Nodes.getNodeAs<FunctionDecl>("function_decl")->getName()); + if (!Scale) + return; + + if (isInMacro(Result, Binop->getLHS()) || isInMacro(Result, Binop->getRHS())) + return; + + // In most cases, we'll only need to rewrite one of the sides, but we also + // want to handle the case of rewriting both sides. This is much simpler if + // we unconditionally try and rewrite both, and let the rewriter determine + // if nothing needs to be done. + std::string LhsReplacement = + rewriteExprFromNumberToTime(Result, *Scale, Binop->getLHS()); + std::string RhsReplacement = + rewriteExprFromNumberToTime(Result, *Scale, Binop->getRHS()); + + diag(Binop->getBeginLoc(), "perform comparison in the time domain") + << FixItHint::CreateReplacement(Binop->getSourceRange(), + (llvm::Twine(LhsReplacement) + " " + + Binop->getOpcodeStr() + " " + + RhsReplacement) + .str()); +} + +} // namespace abseil +} // namespace tidy +} // namespace clang |