blob: 92d787960e08fd065ac27e68faa1aa66d17b47e7 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
|
//===--- StaticAccessedThroughInstanceCheck.cpp - clang-tidy---------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
#include "StaticAccessedThroughInstanceCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace readability {
static unsigned getNameSpecifierNestingLevel(const QualType &QType) {
if (const ElaboratedType *ElType = QType->getAs<ElaboratedType>()) {
const NestedNameSpecifier *NestedSpecifiers = ElType->getQualifier();
unsigned NameSpecifierNestingLevel = 1;
do {
NameSpecifierNestingLevel++;
NestedSpecifiers = NestedSpecifiers->getPrefix();
} while (NestedSpecifiers);
return NameSpecifierNestingLevel;
}
return 0;
}
void StaticAccessedThroughInstanceCheck::storeOptions(
ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "NameSpecifierNestingThreshold",
NameSpecifierNestingThreshold);
}
void StaticAccessedThroughInstanceCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()),
varDecl(hasStaticStorageDuration()))),
unless(isInTemplateInstantiation()))
.bind("memberExpression"),
this);
}
void StaticAccessedThroughInstanceCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *MemberExpression =
Result.Nodes.getNodeAs<MemberExpr>("memberExpression");
if (MemberExpression->getBeginLoc().isMacroID())
return;
const Expr *BaseExpr = MemberExpression->getBase();
// Do not warn for overlaoded -> operators.
if (isa<CXXOperatorCallExpr>(BaseExpr))
return;
QualType BaseType =
BaseExpr->getType()->isPointerType()
? BaseExpr->getType()->getPointeeType().getUnqualifiedType()
: BaseExpr->getType().getUnqualifiedType();
const ASTContext *AstContext = Result.Context;
PrintingPolicy PrintingPolicyWithSupressedTag(AstContext->getLangOpts());
PrintingPolicyWithSupressedTag.SuppressTagKeyword = true;
std::string BaseTypeName =
BaseType.getAsString(PrintingPolicyWithSupressedTag);
SourceLocation MemberExprStartLoc = MemberExpression->getBeginLoc();
auto Diag =
diag(MemberExprStartLoc, "static member accessed through instance");
if (BaseExpr->HasSideEffects(*AstContext) ||
getNameSpecifierNestingLevel(BaseType) > NameSpecifierNestingThreshold)
return;
Diag << FixItHint::CreateReplacement(
CharSourceRange::getCharRange(MemberExprStartLoc,
MemberExpression->getMemberLoc()),
BaseTypeName + "::");
}
} // namespace readability
} // namespace tidy
} // namespace clang
|
