blob: 18fe5ef4e5c2c7936a54f43928488ee441633b20 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
|
// RUN: %check_clang_tidy %s bugprone-string-integer-assignment %t
namespace std {
template<typename T>
struct basic_string {
basic_string& operator=(T);
basic_string& operator=(basic_string);
basic_string& operator+=(T);
basic_string& operator+=(basic_string);
const T &operator[](int i) const;
T &operator[](int i);
};
typedef basic_string<char> string;
typedef basic_string<wchar_t> wstring;
int tolower(int i);
int toupper(int i);
}
int tolower(int i);
int toupper(int i);
typedef int MyArcaneChar;
constexpr char kCharConstant = 'a';
int main() {
std::string s;
std::wstring ws;
int x = 5;
const char c = 'c';
s = 6;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: an integer is interpreted as a character code when assigning {{.*}} [bugprone-string-integer-assignment]
// CHECK-FIXES: {{^}} s = '6';{{$}}
s = 66;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} s = "66";{{$}}
s = x;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} s = std::to_string(x);{{$}}
s = 'c';
s = static_cast<char>(6);
// +=
ws += 6;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} ws += L'6';{{$}}
ws += 66;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} ws += L"66";{{$}}
ws += x;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} ws += std::to_wstring(x);{{$}}
ws += L'c';
ws += (wchar_t)6;
std::basic_string<MyArcaneChar> as;
as = 6;
as = static_cast<MyArcaneChar>(6);
as = 'a';
s += toupper(x);
s += tolower(x);
s += (std::tolower(x));
s += c & s[1];
s += c ^ s[1];
s += c | s[1];
s[x] += 1;
s += s[x];
as += as[x];
// Likely character expressions.
s += x & 0xff;
s += 0xff & x;
s += x % 26;
s += 26 % x;
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} s += std::to_string(26 % x);{{$}}
s += c | 0x80;
s += c | 0x8000;
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} s += std::to_string(c | 0x8000);{{$}}
as += c | 0x8000;
s += 'a' + (x % 26);
s += kCharConstant + (x % 26);
s += 'a' + (s[x] & 0xf);
s += (x % 10) + 'b';
s += x > 255 ? c : x;
s += x > 255 ? 12 : x;
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: an integer is interpreted as a chara
// CHECK-FIXES: {{^}} s += std::to_string(x > 255 ? 12 : x);{{$}}
}
namespace instantiation_dependent_exprs {
template<typename T>
struct S {
static constexpr T t = 0x8000;
std::string s;
void f(char c) { s += c | static_cast<int>(t); }
};
template S<int>;
}
|
