diff options
author | Alp Toker <alp@nuanti.com> | 2014-05-21 01:12:41 +0000 |
---|---|---|
committer | Alp Toker <alp@nuanti.com> | 2014-05-21 01:12:41 +0000 |
commit | 16b97825c5c0fc1aa5da7caa355e611695325370 (patch) | |
tree | c2a6445f8a243ee3018fc11e2840f492a6cf1f73 | |
parent | 041c5c150c840bd5779081f8c8de53f2dca38d23 (diff) |
SourceManager: Use setMainFileID() consistently
Eliminate createMainFileID() / createMainFileIDForMemBuffer() utility
functions. These didn't add much convenience and conflated two distinct
operations.
This change makes things easier to follow by providing a consistent interface
and getting rid of a bunch of cast-to-voids.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@209266 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | include/clang/Basic/SourceManager.h | 20 | ||||
-rw-r--r-- | lib/Frontend/CompilerInstance.cpp | 8 | ||||
-rw-r--r-- | unittests/Basic/SourceManagerTest.cpp | 11 | ||||
-rw-r--r-- | unittests/Lex/LexerTest.cpp | 2 | ||||
-rw-r--r-- | unittests/Lex/PPCallbacksTest.cpp | 4 | ||||
-rw-r--r-- | unittests/Lex/PPConditionalDirectiveRecordTest.cpp | 2 |
6 files changed, 16 insertions, 31 deletions
diff --git a/include/clang/Basic/SourceManager.h b/include/clang/Basic/SourceManager.h index 31f1b8f8bb..bea4890ca4 100644 --- a/include/clang/Basic/SourceManager.h +++ b/include/clang/Basic/SourceManager.h @@ -746,18 +746,6 @@ public: StoredModuleBuildStack.push_back(std::make_pair(moduleName.str(),importLoc)); } - /// \brief Create the FileID for a memory buffer that will represent the - /// FileID for the main source. - /// - /// One example of when this would be used is when the main source is read - /// from STDIN. - FileID createMainFileIDForMemBuffer(const llvm::MemoryBuffer *Buffer, - SrcMgr::CharacteristicKind Kind = SrcMgr::C_User) { - assert(MainFileID.isInvalid() && "MainFileID already set!"); - MainFileID = createFileID(Buffer, Kind); - return MainFileID; - } - //===--------------------------------------------------------------------===// // MainFileID creation and querying methods. //===--------------------------------------------------------------------===// @@ -765,14 +753,6 @@ public: /// \brief Returns the FileID of the main source file. FileID getMainFileID() const { return MainFileID; } - /// \brief Create the FileID for the main source file. - FileID createMainFileID(const FileEntry *SourceFile, - SrcMgr::CharacteristicKind Kind = SrcMgr::C_User) { - assert(MainFileID.isInvalid() && "MainFileID already set!"); - MainFileID = createFileID(SourceFile, SourceLocation(), Kind); - return MainFileID; - } - /// \brief Set the file ID for the main source file. void setMainFileID(FileID FID) { assert(MainFileID.isInvalid() && "MainFileID already set!"); diff --git a/lib/Frontend/CompilerInstance.cpp b/lib/Frontend/CompilerInstance.cpp index 9e07e747e8..822b44e442 100644 --- a/lib/Frontend/CompilerInstance.cpp +++ b/lib/Frontend/CompilerInstance.cpp @@ -621,7 +621,7 @@ bool CompilerInstance::InitializeSourceManager(const FrontendInputFile &Input, Kind = Input.isSystem() ? SrcMgr::C_System : SrcMgr::C_User; if (Input.isBuffer()) { - SourceMgr.createMainFileIDForMemBuffer(Input.getBuffer(), Kind); + SourceMgr.setMainFileID(SourceMgr.createFileID(Input.getBuffer(), Kind)); assert(!SourceMgr.getMainFileID().isInvalid() && "Couldn't establish MainFileID!"); return true; @@ -655,7 +655,8 @@ bool CompilerInstance::InitializeSourceManager(const FrontendInputFile &Input, } } - SourceMgr.createMainFileID(File, Kind); + SourceMgr.setMainFileID( + SourceMgr.createFileID(File, SourceLocation(), Kind)); } else { std::unique_ptr<llvm::MemoryBuffer> SB; if (llvm::error_code ec = llvm::MemoryBuffer::getSTDIN(SB)) { @@ -664,7 +665,8 @@ bool CompilerInstance::InitializeSourceManager(const FrontendInputFile &Input, } const FileEntry *File = FileMgr.getVirtualFile(SB->getBufferIdentifier(), SB->getBufferSize(), 0); - SourceMgr.createMainFileID(File, Kind); + SourceMgr.setMainFileID( + SourceMgr.createFileID(File, SourceLocation(), Kind)); SourceMgr.overrideFileContents(File, SB.release()); } diff --git a/unittests/Basic/SourceManagerTest.cpp b/unittests/Basic/SourceManagerTest.cpp index 36e6a5578b..f227d0d6fd 100644 --- a/unittests/Basic/SourceManagerTest.cpp +++ b/unittests/Basic/SourceManagerTest.cpp @@ -75,7 +75,8 @@ TEST_F(SourceManagerTest, isBeforeInTranslationUnit) { "#define M(x) [x]\n" "M(foo)"; MemoryBuffer *buf = MemoryBuffer::getMemBuffer(source); - FileID mainFileID = SourceMgr.createMainFileIDForMemBuffer(buf); + FileID mainFileID = SourceMgr.createFileID(buf); + SourceMgr.setMainFileID(mainFileID); VoidModuleLoader ModLoader; HeaderSearch HeaderInfo(new HeaderSearchOptions, SourceMgr, Diags, LangOpts, @@ -127,7 +128,8 @@ TEST_F(SourceManagerTest, getColumnNumber) { "int y;"; MemoryBuffer *Buf = MemoryBuffer::getMemBuffer(Source); - FileID MainFileID = SourceMgr.createMainFileIDForMemBuffer(Buf); + FileID MainFileID = SourceMgr.createFileID(Buf); + SourceMgr.setMainFileID(MainFileID); bool Invalid; @@ -186,7 +188,8 @@ TEST_F(SourceManagerTest, getMacroArgExpandedLocation) { MemoryBuffer *headerBuf = MemoryBuffer::getMemBuffer(header); MemoryBuffer *mainBuf = MemoryBuffer::getMemBuffer(main); - FileID mainFileID = SourceMgr.createMainFileIDForMemBuffer(mainBuf); + FileID mainFileID = SourceMgr.createFileID(mainBuf); + SourceMgr.setMainFileID(mainFileID); const FileEntry *headerFile = FileMgr.getVirtualFile("/test-header.h", headerBuf->getBufferSize(), 0); @@ -284,7 +287,7 @@ TEST_F(SourceManagerTest, isBeforeInTranslationUnitWithMacroInInclude) { MemoryBuffer *headerBuf = MemoryBuffer::getMemBuffer(header); MemoryBuffer *mainBuf = MemoryBuffer::getMemBuffer(main); - SourceMgr.createMainFileIDForMemBuffer(mainBuf); + SourceMgr.setMainFileID(SourceMgr.createFileID(mainBuf)); const FileEntry *headerFile = FileMgr.getVirtualFile("/test-header.h", headerBuf->getBufferSize(), 0); diff --git a/unittests/Lex/LexerTest.cpp b/unittests/Lex/LexerTest.cpp index 7be9360a59..3d30352d48 100644 --- a/unittests/Lex/LexerTest.cpp +++ b/unittests/Lex/LexerTest.cpp @@ -64,7 +64,7 @@ protected: std::vector<Token> CheckLex(StringRef Source, ArrayRef<tok::TokenKind> ExpectedTokens) { MemoryBuffer *buf = MemoryBuffer::getMemBuffer(Source); - (void) SourceMgr.createMainFileIDForMemBuffer(buf); + SourceMgr.setMainFileID(SourceMgr.createFileID(buf)); VoidModuleLoader ModLoader; HeaderSearch HeaderInfo(new HeaderSearchOptions, SourceMgr, Diags, LangOpts, diff --git a/unittests/Lex/PPCallbacksTest.cpp b/unittests/Lex/PPCallbacksTest.cpp index 25dc7db53e..cceebea6c1 100644 --- a/unittests/Lex/PPCallbacksTest.cpp +++ b/unittests/Lex/PPCallbacksTest.cpp @@ -163,7 +163,7 @@ protected: CharSourceRange InclusionDirectiveFilenameRange(const char* SourceText, const char* HeaderPath, bool SystemHeader) { MemoryBuffer *Buf = MemoryBuffer::getMemBuffer(SourceText); - (void)SourceMgr.createMainFileIDForMemBuffer(Buf); + SourceMgr.setMainFileID(SourceMgr.createFileID(Buf)); VoidModuleLoader ModLoader; @@ -200,7 +200,7 @@ protected: OpenCLLangOpts.OpenCL = 1; MemoryBuffer* sourceBuf = MemoryBuffer::getMemBuffer(SourceText, "test.cl"); - (void)SourceMgr.createMainFileIDForMemBuffer(sourceBuf); + SourceMgr.setMainFileID(SourceMgr.createFileID(sourceBuf)); VoidModuleLoader ModLoader; HeaderSearch HeaderInfo(new HeaderSearchOptions, SourceMgr, Diags, diff --git a/unittests/Lex/PPConditionalDirectiveRecordTest.cpp b/unittests/Lex/PPConditionalDirectiveRecordTest.cpp index ff81fa0bb6..f7ed8e54fc 100644 --- a/unittests/Lex/PPConditionalDirectiveRecordTest.cpp +++ b/unittests/Lex/PPConditionalDirectiveRecordTest.cpp @@ -92,7 +92,7 @@ TEST_F(PPConditionalDirectiveRecordTest, PPRecAPI) { "9\n"; MemoryBuffer *buf = MemoryBuffer::getMemBuffer(source); - SourceMgr.createMainFileIDForMemBuffer(buf); + SourceMgr.setMainFileID(SourceMgr.createFileID(buf)); VoidModuleLoader ModLoader; HeaderSearch HeaderInfo(new HeaderSearchOptions, SourceMgr, Diags, LangOpts, |