diff options
author | David Blaikie <dblaikie@gmail.com> | 2015-01-13 23:06:27 +0000 |
---|---|---|
committer | David Blaikie <dblaikie@gmail.com> | 2015-01-13 23:06:27 +0000 |
commit | 146201a099b2e407f2f6ecd96cbdb68c99cdcdb4 (patch) | |
tree | 63dbd857ceaf2155247cda381b1c929a503daad7 | |
parent | dee97ba884a96100a248dd74832489711ee827a2 (diff) |
DebugInfo: Correct the location of EH cleanup for blocks
This was previously piggybacking on whatever happened to be the last
location set on CGDebugInfo/DIBuilder, which was wrong (it was often the
current location, such as the 'fn()' call site, not the end of the
block). With my improvements to set/unset the location in a scoped
manner (r225000) this went from a bad quality situation, to a crash.
Fixing this goes part-way to unblocking the recommit of r225000.
It's likely that any call to CodeGenFunction::StartFunction without the
CurEHLocation set represents a similar bug or risk of a bug. Perhaps
there are some callers that know they won't generate EH cleanups, but
I'm not sure.
I considered a generic catch-fix in StartFunction (just fallback to the
GlobalDecl's location) but that seemed like it'd mask bugs where the EH
location shouldn't be the same as the decl's location (& indeed by not
using that stop-gap I found this bug). We'll see how long I can hold out
on the generic catch-all. I might eventually be able to add an assertion
in.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@225845 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/CodeGen/CGBlocks.cpp | 2 | ||||
-rw-r--r-- | test/CodeGenObjCXX/debug-info-line.mm | 16 |
2 files changed, 18 insertions, 0 deletions
diff --git a/lib/CodeGen/CGBlocks.cpp b/lib/CodeGen/CGBlocks.cpp index 24611e5175..9db1b7a17b 100644 --- a/lib/CodeGen/CGBlocks.cpp +++ b/lib/CodeGen/CGBlocks.cpp @@ -1107,6 +1107,8 @@ CodeGenFunction::GenerateBlockFunction(GlobalDecl GD, const BlockDecl *blockDecl = blockInfo.getBlockDecl(); CurGD = GD; + + CurEHLocation = blockInfo.getBlockExpr()->getLocEnd(); BlockInfo = &blockInfo; diff --git a/test/CodeGenObjCXX/debug-info-line.mm b/test/CodeGenObjCXX/debug-info-line.mm new file mode 100644 index 0000000000..f38ab5f28a --- /dev/null +++ b/test/CodeGenObjCXX/debug-info-line.mm @@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -fcxx-exceptions -fexceptions -gline-tables-only -fblocks -emit-llvm %s -o - | FileCheck %s + +void fn(); + +struct foo { + ~foo(); +}; + +void func() { + ^{ + foo f; + fn(); + // CHECK: cleanup, !dbg [[LINE:![0-9]*]] + // CHECK: [[LINE]] = !{i32 [[@LINE+1]], + }(); +} |