diff options
| author | Hans Wennborg <hans@hanshq.net> | 2019-09-17 10:19:31 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2019-09-17 10:19:31 +0000 |
| commit | 45898f3be1d37727502cd6342b14c19e7c94bfae (patch) | |
| tree | 046ab74d9519874f1e6f4314f899a7a093bdb020 | |
| parent | 9f8ce132b4a9c416d054c0ef1534d6d5b16f3189 (diff) | |
Merging r371969:
------------------------------------------------------------------------
r371969 | karka | 2019-09-16 11:52:23 +0200 (Mon, 16 Sep 2019) | 13 lines
Change signature of __builtin_rotateright64 back to unsigned
The signature of __builtin_rotateright64 was by misstake changed from
unsigned to signed in r360863, this patch will change it back to
unsigned as intended.
This fixes pr43309
Reviewers: efriedma, hans
Reviewed By: hans
Differential Revision: https://reviews.llvm.org/D67606
------------------------------------------------------------------------
git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_90@372100 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/clang/Basic/Builtins.def | 2 | ||||
| -rw-r--r-- | test/CodeGen/avr-builtins.c | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/include/clang/Basic/Builtins.def b/include/clang/Basic/Builtins.def index 984e607a2f..08c999af1f 100644 --- a/include/clang/Basic/Builtins.def +++ b/include/clang/Basic/Builtins.def @@ -440,7 +440,7 @@ BUILTIN(__builtin_rotateleft64, "UWiUWiUWi", "nc") BUILTIN(__builtin_rotateright8, "UcUcUc", "nc") BUILTIN(__builtin_rotateright16, "UsUsUs", "nc") BUILTIN(__builtin_rotateright32, "UZiUZiUZi", "nc") -BUILTIN(__builtin_rotateright64, "UWiUWiWi", "nc") +BUILTIN(__builtin_rotateright64, "UWiUWiUWi", "nc") // Random GCC builtins BUILTIN(__builtin_constant_p, "i.", "nctu") diff --git a/test/CodeGen/avr-builtins.c b/test/CodeGen/avr-builtins.c index cbba6b2f2a..8fa983a782 100644 --- a/test/CodeGen/avr-builtins.c +++ b/test/CodeGen/avr-builtins.c @@ -1,5 +1,9 @@ // RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s +// Check that the parameter types match. This verifies pr43309. +// RUN: %clang_cc1 -triple avr-unknown-unknown -Wconversion -verify %s +// expected-no-diagnostics + unsigned char bitrev8(unsigned char data) { return __builtin_bitreverse8(data); } |