diff options
author | George Karpenkov <ekarpenkov@apple.com> | 2018-07-16 20:32:57 +0000 |
---|---|---|
committer | George Karpenkov <ekarpenkov@apple.com> | 2018-07-16 20:32:57 +0000 |
commit | 83baf9557f669f3c12debbf41827c1ae34bb2f43 (patch) | |
tree | dad78081a596a35ca8e7eba6d5ca87ec5ccd3519 | |
parent | e75ddf8c13756ad41aafcb557b51a3f8e95913b9 (diff) |
[analyzer] Fix GCDAntipatternChecker to only fire when the semaphore is initialized to zero
Initializing a semaphore with a different constant most likely signals a different intent
rdar://41802552
Differential Revision: https://reviews.llvm.org/D48911
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@337212 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp | 4 | ||||
-rw-r--r-- | test/Analysis/gcdantipatternchecker_test.m | 10 |
2 files changed, 13 insertions, 1 deletions
diff --git a/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp b/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp index 1b7ea53aea..5cb51b01f0 100644 --- a/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp @@ -93,7 +93,9 @@ static bool isTest(const Decl *D) { static auto findGCDAntiPatternWithSemaphore() -> decltype(compoundStmt()) { const char *SemaphoreBinding = "semaphore_name"; - auto SemaphoreCreateM = callExpr(callsName("dispatch_semaphore_create")); + auto SemaphoreCreateM = callExpr(allOf( + callsName("dispatch_semaphore_create"), + hasArgument(0, ignoringParenCasts(integerLiteral(equals(0)))))); auto SemaphoreBindingM = anyOf( forEachDescendant( diff --git a/test/Analysis/gcdantipatternchecker_test.m b/test/Analysis/gcdantipatternchecker_test.m index adc7a52bf5..24ffe8975d 100644 --- a/test/Analysis/gcdantipatternchecker_test.m +++ b/test/Analysis/gcdantipatternchecker_test.m @@ -333,3 +333,13 @@ void dispatch_group_and_semaphore_use(MyInterface1 *M) { }]; dispatch_semaphore_wait(sema1, 100); // expected-warning{{Waiting on a callback using a semaphore}} } + +void no_warn_on_nonzero_semaphore(MyInterface1 *M) { + dispatch_semaphore_t sema1 = dispatch_semaphore_create(1); + + [M acceptBlock:^{ + dispatch_semaphore_signal(sema1); + }]; + dispatch_semaphore_wait(sema1, 100); // no-warning +} + |