diff options
| author | Erich Keane <erich.keane@intel.com> | 2017-10-27 18:32:23 +0000 |
|---|---|---|
| committer | Erich Keane <erich.keane@intel.com> | 2017-10-27 18:32:23 +0000 |
| commit | 0cb2a76a4f9397e6b33d60159f0197d1bcb898e9 (patch) | |
| tree | 87a0ce73e3e535a7b44f64b608bd0f4c76c8e1de /include/clang/Basic/TargetInfo.h | |
| parent | d86c46ef9674cc4f45d296ebd48263588ca3744c (diff) | |
Filter out invalid 'target' items from being passed to LLVM
Craig noticed that CodeGen wasn't properly ignoring the
values sent to the target attribute. This patch ignores
them.
This patch also sets the 'default' for this checking to
'supported', since only X86 has implemented the support
for checking valid CPU names and Feature Names.
One test was changed to i686, since it uses a lakemont,
which would otherwise be prohibited in x86_64.
Differential Revision: https://reviews.llvm.org/D39357
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@316783 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include/clang/Basic/TargetInfo.h')
| -rw-r--r-- | include/clang/Basic/TargetInfo.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/clang/Basic/TargetInfo.h b/include/clang/Basic/TargetInfo.h index 046c3317b5..f80f6b7a6b 100644 --- a/include/clang/Basic/TargetInfo.h +++ b/include/clang/Basic/TargetInfo.h @@ -861,7 +861,7 @@ public: /// brief Determine whether this TargetInfo supports the given CPU name. virtual bool isValidCPUName(StringRef Name) const { - return false; + return true; } /// \brief Use the specified ABI. @@ -888,7 +888,7 @@ public: /// \brief Determine whether this TargetInfo supports the given feature. virtual bool isValidFeatureName(StringRef Feature) const { - return false; + return true; } /// \brief Perform initialization based on the user configured |