diff options
| author | Ted Kremenek <kremenek@apple.com> | 2009-04-08 18:49:36 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2009-04-08 18:49:36 +0000 |
| commit | e42ac98bc2d50506216b6ef258594bdaa59c47c1 (patch) | |
| tree | d29e9ba56abb24ea898a7be3629ad9fefb840d02 /lib/AST/ParentMap.cpp | |
| parent | de076650fa79a02743b5fe57a72f991ba24779f9 (diff) | |
Fix bug in ParentMap::isConsumedExpr. A BinaryOperator always "consumes" the
value of its subexpressions unless it is a comma (in which case it doesn't
consume the left subexpression).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68628 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/AST/ParentMap.cpp')
| -rw-r--r-- | lib/AST/ParentMap.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/AST/ParentMap.cpp b/lib/AST/ParentMap.cpp index 877b43b6de..33731c63ed 100644 --- a/lib/AST/ParentMap.cpp +++ b/lib/AST/ParentMap.cpp @@ -66,7 +66,9 @@ bool ParentMap::isConsumedExpr(Expr* E) const { return true; case Stmt::BinaryOperatorClass: { BinaryOperator *BE = cast<BinaryOperator>(P); - return BE->getOpcode()==BinaryOperator::Comma && DirectChild==BE->getLHS(); + // If it is a comma, only the left side is consumed. + // If it isn't a comma, both sides are consumed. + return BE->getOpcode()!=BinaryOperator::Comma || DirectChild==BE->getLHS(); } case Stmt::ForStmtClass: return DirectChild == cast<ForStmt>(P)->getCond(); |