diff options
| author | John McCall <rjmccall@apple.com> | 2011-03-27 09:00:25 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2011-03-27 09:00:25 +0000 |
| commit | bda0d6bda0f1a08a9fdf3ee4cf550b6b10d454ec (patch) | |
| tree | faa32ab477113bf721c56a359e9019611e2125e9 /lib/CodeGen/CGVTables.h | |
| parent | cc8770a94decad87a048b08a809a0cd9ded1c573 (diff) | |
We were emitting construction v-tables with internal linkage all the time.
Emit them instead with the linkage of the VTT.
I'm actually really ambivalent about this; it's what GCC does, but outside
of improving code size (if the linkage is coalescing), I'm not sure it's
at all relevant. Construction vtables are naturally referenced only by the
VTT, which is itself only referenced by complete-object constructors and
destructors; giving the construction vtables possibly-external linkage is
important if you have an optimization that drills through the VTT to a
reference to a particular construction vtable which it cannot just emit
itself.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@128374 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CGVTables.h')
| -rw-r--r-- | lib/CodeGen/CGVTables.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/CodeGen/CGVTables.h b/lib/CodeGen/CGVTables.h index 7197a57298..b2f9401858 100644 --- a/lib/CodeGen/CGVTables.h +++ b/lib/CodeGen/CGVTables.h @@ -1,4 +1,4 @@ -//===--- CGVTables.h - Emit LLVM Code for C++ vtables ---------------------===// +//===--- CGVTables.h - Emit LLVM Code for C++ vtables -----------*- C++ -*-===// // // The LLVM Compiler Infrastructure // @@ -260,6 +260,7 @@ public: llvm::GlobalVariable * GenerateConstructionVTable(const CXXRecordDecl *RD, const BaseSubobject &Base, bool BaseIsVirtual, + llvm::GlobalVariable::LinkageTypes Linkage, VTableAddressPointsMapTy& AddressPoints); |