Refactor to make MacroState ownership and lifetime clearer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@236032 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 4 insertions, 1 deletions

diff --git a/lib/Lex/PPLexerChange.cpp b/lib/Lex/PPLexerChange.cpp
index 57110aa246..3f0c2bb277 100644
--- a/lib/Lex/PPLexerChange.cpp
+++ b/lib/Lex/PPLexerChange.cpp
@@ -638,6 +638,8 @@ void Preprocessor::LeaveSubmodule() {
     bool ExplicitlyPublic = false;
     for (auto *MD = Macro.second.getLatest(); MD != SavedInfo.Latest;
          MD = MD->getPrevious()) {
+      assert(MD && "broken macro directive chain");
+
       // Skip macros defined in other submodules we #included along the way.
       Module *Mod = getModuleContainingLocation(MD->getLocation());
       if (Mod != Info.M)
@@ -673,7 +675,8 @@ void Preprocessor::LeaveSubmodule() {
     Info.M->NameVisibility = Module::MacrosVisible;
     Info.M->MacroVisibilityLoc = Info.ImportLoc;
     ++MacroVisibilityGeneration;
-    // FIXME: Also mark any exported macros as visible, and check for conflicts.
+    // FIXME: Also mark any exported modules as visible, and check for
+    // conflicts.
   }
 
   BuildingSubmoduleStack.pop_back();