ObjectiveC. Remove false positive warning for missing property

backing ivar by not issuing this warning if ivar is referenced
somewhere and accessor makes method calls. // rdar://15727325


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@198367 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 8 insertions, 3 deletions

diff --git a/lib/Sema/SemaDeclObjC.cpp b/lib/Sema/SemaDeclObjC.cpp
index 7024cf6cb3..edbd714184 100644
--- a/lib/Sema/SemaDeclObjC.cpp
+++ b/lib/Sema/SemaDeclObjC.cpp
@@ -3521,8 +3521,13 @@ void Sema::DiagnoseUnusedBackingIvarInAccessor(Scope *S) {
   const ObjCPropertyDecl *PDecl;
   const ObjCIvarDecl *IV = GetIvarBackingPropertyAccessor(CurMethod, PDecl);
   if (IV && !IV->getBackingIvarReferencedInAccessor()) {
-    Diag(getCurMethodDecl()->getLocation(), diag::warn_unused_property_backing_ivar)
-    << IV->getDeclName();
-    Diag(PDecl->getLocation(), diag::note_property_declare);
+    // Do not issue this warning if backing ivar is used somewhere and accessor
+    // implementation makes a call to a method. This is to prevent false positive in
+    // some corner cases.
+    if (!IV->isReferenced() || !CurMethod->getMethodCallsMethod()) {
+      Diag(getCurMethodDecl()->getLocation(), diag::warn_unused_property_backing_ivar)
+        << IV->getDeclName();
+      Diag(PDecl->getLocation(), diag::note_property_declare);
+    }
   }
 }