P0145R3 (C++17 evaluation order tweaks): consistently emit the LHS of array

subscripting before the RHS, regardless of which is the base and which is the
index.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@282453 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 214 insertions, 0 deletions

diff --git a/test/CodeGenCXX/cxx1z-eval-order.cpp b/test/CodeGenCXX/cxx1z-eval-order.cpp
new file mode 100644
index 0000000000..3531891d38
--- /dev/null
+++ b/test/CodeGenCXX/cxx1z-eval-order.cpp
@@ -0,0 +1,214 @@
+// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - -triple %itanium_abi_triple | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-ITANIUM
+// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - -triple %ms_abi_triple | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-WINDOWS
+
+struct B;
+struct A {
+  A();
+  A(const A&);
+
+  void operator[](B b);
+
+  int a_member_f(B);
+};
+struct B {
+  B();
+  ~B();
+};
+
+struct C {
+  operator int *();
+  A *operator->();
+  void operator->*(B);
+
+  friend void operator<<(C, B);
+  friend void operator>>(C, B);
+  void operator<<(A);
+  void operator>>(A);
+
+  void operator=(B);
+  void operator+=(B);
+};
+
+A make_a();
+A *make_a_ptr();
+int A::*make_mem_ptr_a();
+void (A::*make_mem_fn_ptr_a())();
+B make_b();
+C make_c();
+void side_effect();
+
+void callee(A);
+void (*get_f())(A);
+
+
+// CHECK-LABEL: define {{.*}}@{{.*}}postfix_before_args{{.*}}(
+void postfix_before_args() {
+  // CHECK: call {{.*}}@{{.*}}get_f{{.*}}(
+  // CHECK-ITANIUM: call {{.*}}@_ZN1AC1Ev(
+  // CHECK-WINDOWS: call {{.*}}@"\01??0A@@QEAA@XZ"(
+  // CHECK: call {{.*}}%{{.*}}(
+  get_f()(A{});
+
+  // CHECK: call {{.*}}@{{.*}}side_effect{{.*}}(
+  // CHECK-ITANIUM: call {{.*}}@_ZN1AC1Ev(
+  // CHECK-WINDOWS: call {{.*}}@"\01??0A@@QEAA@XZ"(
+  // CHECK: call {{.*}}@{{.*}}callee{{.*}}(
+  (side_effect(), callee)(A{});
+// CHECK: }
+}
+
+
+// CHECK-LABEL: define {{.*}}@{{.*}}dot_lhs_before_rhs{{.*}}(
+void dot_lhs_before_rhs() {
+  // CHECK: call {{.*}}@{{.*}}make_a{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}make_b{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}a_member_f{{.*}}(
+  make_a().a_member_f(make_b());
+
+  // CHECK: call {{.*}}@{{.*}}make_a_ptr{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}make_b{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}a_member_f{{.*}}(
+  make_a_ptr()->a_member_f(make_b());
+
+  // CHECK: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}make_b{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}a_member_f{{.*}}(
+  make_c()->a_member_f(make_b());
+// CHECK: }
+}
+
+
+// CHECK-LABEL: define {{.*}}@{{.*}}array_lhs_before_rhs{{.*}}(
+void array_lhs_before_rhs() {
+  int (&get_arr())[10];
+  extern int get_index();
+
+  // CHECK: call {{.*}}@{{.*}}get_arr{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}get_index{{.*}}(
+  get_arr()[get_index()] = 0;
+
+  // CHECK: call {{.*}}@{{.*}}get_index{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}get_arr{{.*}}(
+  get_index()[get_arr()] = 0;
+
+  // CHECK: call {{.*}}@{{.*}}make_a{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}make_b{{.*}}(
+  // CHECK: call
+  make_a()[make_b()];
+
+  // CHECK: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}get_index{{.*}}(
+  // CHECK: call
+  make_c()[get_index()] = 0;
+
+  // CHECK: call {{.*}}@{{.*}}get_index{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECK: call
+  get_index()[make_c()] = 0;
+// CHECK: }
+}
+
+
+void *operator new(decltype(sizeof(0)), C);
+
+// CHECK-LABEL: define {{.*}}@{{.*}}alloc_before_init{{.*}}(
+void alloc_before_init() {
+  struct Q { Q(A) {} };
+  // CHECK-ITANIUM: call {{.*}}@_Znw{{.*}}(
+  // CHECK-WINDOWS: call {{.*}}@"\01??2@YAPEAX_K@Z"(
+  // CHECK: call {{.*}}@{{.*}}make_a{{.*}}(
+  delete new Q(make_a());
+
+  // CHECK: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECK: call {{.*}}@{{.*}}make_a{{.*}}(
+  new (make_c()) Q(make_a());
+// CHECK: }
+}
+
+#if 0
+// CHECKDISABLED-LABEL: define {{.*}}@{{.*}}dotstar_lhs_before_rhs{{.*}}(
+int dotstar_lhs_before_rhs() {
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_a{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_mem_ptr_a{{.*}}(
+  int a = make_a().*make_mem_ptr_a();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_a_ptr{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_mem_ptr_a{{.*}}(
+  int b = make_a_ptr()->*make_mem_ptr_a();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_b{{.*}}(
+  make_c()->*make_b();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_a{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_mem_fn_ptr_a{{.*}}(
+  // CHECKDISABLED: call
+  (make_a().*make_mem_fn_ptr_a())();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_a_ptr{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_mem_fn_ptr_a{{.*}}(
+  // CHECKDISABLED: call
+  (make_a_ptr()->*make_mem_fn_ptr_a())();
+
+  return a + b;
+// CHECKDISABLED: }
+}
+#endif
+#if 0
+// CHECKDISABLED-LABEL: define {{.*}}@{{.*}}assign_lhs_before_rhs{{.*}}(
+void assign_rhs_before_lhs() {
+  extern int &lhs_ref(), rhs();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}rhs{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}lhs_ref{{.*}}(
+  lhs_ref() = rhs();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}rhs{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}lhs_ref{{.*}}(
+  lhs_ref() += rhs();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}rhs{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}lhs_ref{{.*}}(
+  lhs_ref() %= rhs();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_b{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_c{{.*}}(
+  make_c() = make_b();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_b{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_c{{.*}}(
+  make_c() += make_b();
+// CHECKDISABLED: }
+}
+#endif
+#if 0
+// CHECKDISABLED-LABEL: define {{.*}}@{{.*}}shift_lhs_before_rhs{{.*}}(
+void shift_lhs_before_rhs() {
+  extern int lhs(), rhs();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}lhs{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}rhs{{.*}}(
+  (void)(lhs() << rhs());
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}lhs{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}rhs{{.*}}(
+  (void)(lhs() >> rhs());
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_a{{.*}}(
+  make_c() << make_a();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_a{{.*}}(
+  make_c() >> make_a();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_b{{.*}}(
+  make_c() << make_b();
+
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_c{{.*}}(
+  // CHECKDISABLED: call {{.*}}@{{.*}}make_b{{.*}}(
+  make_c() >> make_b();
+// CHECKDISABLED: }
+}
+#endif