diff options
| author | Vedant Kumar <vsk@apple.com> | 2017-03-06 05:28:22 +0000 |
|---|---|---|
| committer | Vedant Kumar <vsk@apple.com> | 2017-03-06 05:28:22 +0000 |
| commit | a7325b067d8d0ebf370ffbffb0f861d9252c551c (patch) | |
| tree | 583b903cb68bfd5e30e64ebc2db3f40d6f499747 /test/CodeGenObjC | |
| parent | ed642ad0782597955bdc243bf4198b0699f8834b (diff) | |
[ubsan] Extend the nonnull arg check to ObjC
UBSan's nonnull argument check applies when a parameter has the
"nonnull" attribute. The check currently works for FunctionDecls, but
not for ObjCMethodDecls. This patch extends the check to work for ObjC.
Differential Revision: https://reviews.llvm.org/D30599
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@296996 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CodeGenObjC')
| -rw-r--r-- | test/CodeGenObjC/ubsan-nonnull.m | 48 |
1 files changed, 48 insertions, 0 deletions
diff --git a/test/CodeGenObjC/ubsan-nonnull.m b/test/CodeGenObjC/ubsan-nonnull.m new file mode 100644 index 0000000000..cc0850caf9 --- /dev/null +++ b/test/CodeGenObjC/ubsan-nonnull.m @@ -0,0 +1,48 @@ +// RUN: %clang_cc1 -x objective-c -emit-llvm -triple x86_64-apple-macosx10.10.0 -fsanitize=nonnull-attribute %s -o - -w | FileCheck %s + +@interface A + +-(void) one_arg: (__attribute__((nonnull)) int *) arg1; + +-(void) varargs: (__attribute__((nonnull)) int *) arg1, ...; + ++(void) clsmethod: (__attribute__((nonnull)) int *) arg1; + +@end + +@implementation A + +// CHECK-LABEL: define internal void @"\01-[A one_arg:]" +// CHECK-SAME: i32* nonnull +-(void) one_arg: (__attribute__((nonnull)) int *) arg1 {} + +// CHECK-LABEL: define internal void @"\01-[A varargs:]" +// CHECK-SAME: i32* nonnull +-(void) varargs: (__attribute__((nonnull)) int *) arg1, ... {} + +// CHECK-LABEL: define internal void @"\01+[A clsmethod:]" +// CHECK-SAME: i32* nonnull ++(void) clsmethod: (__attribute__((nonnull)) int *) arg1 {} + +@end + +// CHECK-LABEL: define void @call_A +void call_A(A *a, int *p) { + // CHECK: [[ICMP:%.*]] = icmp ne i32* [[P1:%.*]], null, !nosanitize + // CHECK: br i1 [[ICMP]], {{.*}}, !nosanitize + // CHECK: call void @__ubsan_handle_nonnull_arg{{.*}} !nosanitize + // CHECK: call void {{.*}} @objc_msgSend {{.*}} ({{.*}}, i32* [[P1]]) + [a one_arg: p]; + + // CHECK: [[ICMP:%.*]] = icmp ne i32* [[P2:%.*]], null, !nosanitize + // CHECK: br i1 [[ICMP]], {{.*}}, !nosanitize + // CHECK: call void @__ubsan_handle_nonnull_arg{{.*}} !nosanitize + // CHECK: call void {{.*}} @objc_msgSend {{.*}} ({{.*}}, i32* [[P2]], {{.*}}) + [a varargs: p, p]; + + // CHECK: [[ICMP:%.*]] = icmp ne i32* [[P3:%.*]], null, !nosanitize + // CHECK: br i1 [[ICMP]], {{.*}}, !nosanitize + // CHECK: call void @__ubsan_handle_nonnull_arg{{.*}} !nosanitize + // CHECK: call void {{.*}} @objc_msgSend {{.*}} ({{.*}}, i32* [[P3]]) + [A clsmethod: p]; +} |