diff options
author | Douglas Gregor <dgregor@apple.com> | 2013-06-21 00:20:25 +0000 |
---|---|---|
committer | Douglas Gregor <dgregor@apple.com> | 2013-06-21 00:20:25 +0000 |
commit | fc46be997f8219e11900473c373b639525396064 (patch) | |
tree | 6cc3a56b6f6858ad2b490489592319cdc62cd62b /test/Modules/method_pool.m | |
parent | 7c64ef05e179d29646030e9d453081844ecc537a (diff) |
When building a module, keep *all* declared methods in the global method pool.
As an optimization, we only kept declared methods with distinct
signatures in the global method pool, to keep the method lists
small. Under modules, however, one could have two different methods
with the same signature that occur in different (sub)modules. If only
the later submodule is important, message sends to 'id' with that
selector would fail because the first method (the only one that got
into the method pool) was hidden. When building a module, keep *all*
of the declared methods.
I did a quick check of both module build time and uses of modules, and
found no performance regression despite this causing us to keep more
methods in the global method pool. Fixes <rdar://problem/14148896>.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@184504 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Modules/method_pool.m')
-rw-r--r-- | test/Modules/method_pool.m | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/test/Modules/method_pool.m b/test/Modules/method_pool.m index 6fd74b0885..f7d5ae700c 100644 --- a/test/Modules/method_pool.m +++ b/test/Modules/method_pool.m @@ -47,6 +47,10 @@ void testMethod3Again(id object) { char *str = [object method3]; // okay: only found in MethodPoolB.Sub } +void testMethod6(id object) { + [object method6]; +} + @import MethodPoolA.Sub; void testMethod3AgainAgain(id object) { |