diff options
author | Vedant Kumar <vsk@apple.com> | 2017-09-11 20:47:42 +0000 |
---|---|---|
committer | Vedant Kumar <vsk@apple.com> | 2017-09-11 20:47:42 +0000 |
commit | c9445f041caab06d4aa184cb0e0b15a5d27feeaf (patch) | |
tree | aacf72d3c2454e77902847fc6c70509311e9047b /tools/libclang | |
parent | 440d6c02ac5cfe1d6f777a2d0f61686783c108f1 (diff) |
[Lexer] Report more precise skipped regions (PR34166)
This patch teaches the preprocessor to report more precise source ranges for
code that is skipped due to conditional directives.
The new behavior includes the '#' from the opening directive and the full text
of the line containing the closing directive in the skipped area. This matches
up clang's behavior (we don't IRGen the code between the closing "endif" and
the end of a line).
This also affects the code coverage implementation. See llvm.org/PR34166 (this
also happens to be rdar://problem/23224058).
The old behavior (report the end of the skipped range as the end
location of the 'endif' token) is preserved for indexing clients.
Differential Revision: https://reviews.llvm.org/D36642
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@312947 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/libclang')
-rw-r--r-- | tools/libclang/Indexing.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/libclang/Indexing.cpp b/tools/libclang/Indexing.cpp index 5312b7c016..2a136242ef 100644 --- a/tools/libclang/Indexing.cpp +++ b/tools/libclang/Indexing.cpp @@ -272,7 +272,8 @@ public: /// SourceRangeSkipped - This hook is called when a source range is skipped. /// \param Range The SourceRange that was skipped. The range begins at the /// #if/#else directive and ends after the #endif/#else directive. - void SourceRangeSkipped(SourceRange Range) override {} + void SourceRangeSkipped(SourceRange Range, SourceLocation EndifLoc) override { + } }; //===----------------------------------------------------------------------===// |