From b3cde23af4e18e713453781fd94f1b59be62dc08 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 8 Dec 2014 23:38:45 +0000 Subject: Merging r221748: ------------------------------------------------------------------------ r221748 | richard-llvm | 2014-11-11 20:43:45 -0500 (Tue, 11 Nov 2014) | 4 lines PR21536: Fix a corner case where we'd get confused by a pack expanding into the penultimate parameter of a template parameter list, where the last parameter is itself a pack, and build a bogus empty final pack argument. ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_35@223718 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaTemplate.cpp | 2 +- test/SemaTemplate/deduction.cpp | 18 +++++++++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/lib/Sema/SemaTemplate.cpp b/lib/Sema/SemaTemplate.cpp index 63581a44db..5596a0162b 100644 --- a/lib/Sema/SemaTemplate.cpp +++ b/lib/Sema/SemaTemplate.cpp @@ -3746,7 +3746,7 @@ bool Sema::CheckTemplateArgumentList(TemplateDecl *Template, } // Push the argument pack onto the list of converted arguments. - if (InFinalParameterPack) { + if (InFinalParameterPack && !ArgumentPack.empty()) { Converted.push_back( TemplateArgument::CreatePackCopy(Context, ArgumentPack.data(), diff --git a/test/SemaTemplate/deduction.cpp b/test/SemaTemplate/deduction.cpp index aecb5ee7c8..c089573a9c 100644 --- a/test/SemaTemplate/deduction.cpp +++ b/test/SemaTemplate/deduction.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fsyntax-only -verify %s +// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 // Template argument deduction with template template parameters. template class A> @@ -162,3 +162,19 @@ namespace test14 { foo(a); } } + +namespace PR21536 { + template struct X; + template struct S { + static_assert(sizeof...(B) == 1, ""); + void f() { + using T = A; + using T = int; + + using U = X; + using U = X; + } + }; + template void f(S); + void g() { f(S()); } +} -- cgit v1.2.3