1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
|
// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -pedantic -verify -Wsign-compare -Wtautological-constant-in-range-compare %s -Wno-unreachable-code
// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -pedantic -verify -Wsign-compare -Wtype-limits %s -Wno-unreachable-code
int test(char *C) { // nothing here should warn.
return C != ((void*)0);
return C != (void*)0;
return C != 0;
return C != 1; // expected-warning {{comparison between pointer and integer ('char *' and 'int')}}
}
int ints(long a, unsigned long b) {
enum EnumA {A};
enum EnumB {B};
enum EnumC {C = 0x10000};
return
// (a,b)
(a == (unsigned long) b) + // expected-warning {{comparison of integers of different signs}}
(a == (unsigned int) b) +
(a == (unsigned short) b) +
(a == (unsigned char) b) +
((long) a == b) + // expected-warning {{comparison of integers of different signs}}
((int) a == b) + // expected-warning {{comparison of integers of different signs}}
((short) a == b) + // expected-warning {{comparison of integers of different signs}}
((signed char) a == b) + // expected-warning {{comparison of integers of different signs}}
((long) a == (unsigned long) b) + // expected-warning {{comparison of integers of different signs}}
((int) a == (unsigned int) b) + // expected-warning {{comparison of integers of different signs}}
((short) a == (unsigned short) b) +
((signed char) a == (unsigned char) b) +
(a < (unsigned long) b) + // expected-warning {{comparison of integers of different signs}}
(a < (unsigned int) b) +
(a < (unsigned short) b) +
(a < (unsigned char) b) +
((long) a < b) + // expected-warning {{comparison of integers of different signs}}
((int) a < b) + // expected-warning {{comparison of integers of different signs}}
((short) a < b) + // expected-warning {{comparison of integers of different signs}}
((signed char) a < b) + // expected-warning {{comparison of integers of different signs}}
((long) a < (unsigned long) b) + // expected-warning {{comparison of integers of different signs}}
((int) a < (unsigned int) b) + // expected-warning {{comparison of integers of different signs}}
((short) a < (unsigned short) b) +
((signed char) a < (unsigned char) b) +
// (A,b)
(A == (unsigned long) b) +
(A == (unsigned int) b) +
(A == (unsigned short) b) +
(A == (unsigned char) b) +
((long) A == b) +
((int) A == b) +
((short) A == b) +
((signed char) A == b) +
((long) A == (unsigned long) b) +
((int) A == (unsigned int) b) +
((short) A == (unsigned short) b) +
((signed char) A == (unsigned char) b) +
(A < (unsigned long) b) +
(A < (unsigned int) b) +
(A < (unsigned short) b) +
(A < (unsigned char) b) +
((long) A < b) +
((int) A < b) +
((short) A < b) +
((signed char) A < b) +
((long) A < (unsigned long) b) +
((int) A < (unsigned int) b) +
((short) A < (unsigned short) b) +
((signed char) A < (unsigned char) b) +
// (a,B)
(a == (unsigned long) B) +
(a == (unsigned int) B) +
(a == (unsigned short) B) +
(a == (unsigned char) B) +
((long) a == B) +
((int) a == B) +
((short) a == B) +
((signed char) a == B) +
((long) a == (unsigned long) B) +
((int) a == (unsigned int) B) +
((short) a == (unsigned short) B) +
((signed char) a == (unsigned char) B) +
(a < (unsigned long) B) + // expected-warning {{comparison of unsigned expression < 0 is always false}}
(a < (unsigned int) B) +
(a < (unsigned short) B) +
(a < (unsigned char) B) +
((long) a < B) +
((int) a < B) +
((short) a < B) +
((signed char) a < B) +
((long) a < (unsigned long) B) + // expected-warning {{comparison of unsigned expression < 0 is always false}}
((int) a < (unsigned int) B) + // expected-warning {{comparison of unsigned expression < 0 is always false}}
((short) a < (unsigned short) B) +
((signed char) a < (unsigned char) B) +
// (C,b)
(C == (unsigned long) b) +
(C == (unsigned int) b) +
(C == (unsigned short) b) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'unsigned short' is always false}}
(C == (unsigned char) b) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'unsigned char' is always false}}
((long) C == b) +
((int) C == b) +
((short) C == b) +
((signed char) C == b) +
((long) C == (unsigned long) b) +
((int) C == (unsigned int) b) +
((short) C == (unsigned short) b) +
((signed char) C == (unsigned char) b) +
(C < (unsigned long) b) +
(C < (unsigned int) b) +
(C < (unsigned short) b) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'unsigned short' is always false}}
(C < (unsigned char) b) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'unsigned char' is always false}}
((long) C < b) +
((int) C < b) +
((short) C < b) +
((signed char) C < b) +
((long) C < (unsigned long) b) +
((int) C < (unsigned int) b) +
((short) C < (unsigned short) b) +
((signed char) C < (unsigned char) b) +
// (a,C)
(a == (unsigned long) C) +
(a == (unsigned int) C) +
(a == (unsigned short) C) +
(a == (unsigned char) C) +
((long) a == C) +
((int) a == C) +
((short) a == C) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'short' is always false}}
((signed char) a == C) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'signed char' is always false}}
((long) a == (unsigned long) C) +
((int) a == (unsigned int) C) +
((short) a == (unsigned short) C) +
((signed char) a == (unsigned char) C) +
(a < (unsigned long) C) + // expected-warning {{comparison of integers of different signs}}
(a < (unsigned int) C) +
(a < (unsigned short) C) +
(a < (unsigned char) C) +
((long) a < C) +
((int) a < C) +
((short) a < C) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'short' is always true}}
((signed char) a < C) + // expected-warning {{comparison of constant 'C' (65536) with expression of type 'signed char' is always true}}
((long) a < (unsigned long) C) + // expected-warning {{comparison of integers of different signs}}
((int) a < (unsigned int) C) + // expected-warning {{comparison of integers of different signs}}
((short) a < (unsigned short) C) +
((signed char) a < (unsigned char) C) +
// (0x80000,b)
(0x80000 == (unsigned long) b) +
(0x80000 == (unsigned int) b) +
(0x80000 == (unsigned short) b) + // expected-warning {{comparison of constant 524288 with expression of type 'unsigned short' is always false}}
(0x80000 == (unsigned char) b) + // expected-warning {{comparison of constant 524288 with expression of type 'unsigned char' is always false}}
((long) 0x80000 == b) +
((int) 0x80000 == b) +
((short) 0x80000 == b) +
((signed char) 0x80000 == b) +
((long) 0x80000 == (unsigned long) b) +
((int) 0x80000 == (unsigned int) b) +
((short) 0x80000 == (unsigned short) b) +
((signed char) 0x80000 == (unsigned char) b) +
(0x80000 < (unsigned long) b) +
(0x80000 < (unsigned int) b) +
(0x80000 < (unsigned short) b) + // expected-warning {{comparison of constant 524288 with expression of type 'unsigned short' is always false}}
(0x80000 < (unsigned char) b) + // expected-warning {{comparison of constant 524288 with expression of type 'unsigned char' is always false}}
((long) 0x80000 < b) +
((int) 0x80000 < b) +
((short) 0x80000 < b) +
((signed char) 0x80000 < b) +
((long) 0x80000 < (unsigned long) b) +
((int) 0x80000 < (unsigned int) b) +
((short) 0x80000 < (unsigned short) b) +
((signed char) 0x80000 < (unsigned char) b) +
// (a,0x80000)
(a == (unsigned long) 0x80000) +
(a == (unsigned int) 0x80000) +
(a == (unsigned short) 0x80000) +
(a == (unsigned char) 0x80000) +
((long) a == 0x80000) +
((int) a == 0x80000) +
((short) a == 0x80000) + // expected-warning {{comparison of constant 524288 with expression of type 'short' is always false}}
((signed char) a == 0x80000) + // expected-warning {{comparison of constant 524288 with expression of type 'signed char' is always false}}
((long) a == (unsigned long) 0x80000) +
((int) a == (unsigned int) 0x80000) +
((short) a == (unsigned short) 0x80000) +
((signed char) a == (unsigned char) 0x80000) +
(a < (unsigned long) 0x80000) + // expected-warning {{comparison of integers of different signs}}
(a < (unsigned int) 0x80000) +
(a < (unsigned short) 0x80000) +
(a < (unsigned char) 0x80000) +
((long) a < 0x80000) +
((int) a < 0x80000) +
((short) a < 0x80000) + // expected-warning {{comparison of constant 524288 with expression of type 'short' is always true}}
((signed char) a < 0x80000) + // expected-warning {{comparison of constant 524288 with expression of type 'signed char' is always true}}
((long) a < (unsigned long) 0x80000) + // expected-warning {{comparison of integers of different signs}}
((int) a < (unsigned int) 0x80000) + // expected-warning {{comparison of integers of different signs}}
((short) a < (unsigned short) 0x80000) +
((signed char) a < (unsigned char) 0x80000) +
// We should be able to avoid warning about this.
(b != (a < 4 ? 1 : 2)) +
10
;
}
int equal(char *a, const char *b) {
return a == b;
}
int arrays(char (*a)[5], char(*b)[10], char(*c)[5]) {
int d = (a == c);
return a == b; // expected-warning {{comparison of distinct pointer types}}
}
int pointers(int *a) {
return a > 0; // expected-warning {{ordered comparison between pointer and zero ('int *' and 'int') is an extension}}
return a > 42; // expected-warning {{ordered comparison between pointer and integer ('int *' and 'int')}}
return a > (void *)0; // expected-warning {{comparison of distinct pointer types}}
}
int function_pointers(int (*a)(int), int (*b)(int), void (*c)(int)) {
return a > b; // expected-warning {{ordered comparison of function pointers}}
return function_pointers > function_pointers; // expected-warning {{self-comparison always evaluates to false}} expected-warning{{ordered comparison of function pointers}}
return a > c; // expected-warning {{comparison of distinct pointer types}}
return a == (void *) 0;
return a == (void *) 1; // expected-warning {{equality comparison between function pointer and void pointer}}
}
int void_pointers(void* foo) {
return foo == (void*) 0;
return foo == (void*) 1;
}
int test1(int i) {
enum en { zero };
return i > zero;
}
// PR5937
int test2(int i32) {
struct foo {
unsigned int u8 : 8;
unsigned long long u31 : 31;
unsigned long long u32 : 32;
unsigned long long u63 : 63;
unsigned long long u64 : 64;
} *x;
if (x->u8 == i32) { // comparison in int32, exact
return 0;
} else if (x->u31 == i32) { // comparison in int32, exact
return 1;
} else if (x->u32 == i32) { // expected-warning {{comparison of integers of different signs}}
return 2;
} else if (x->u63 == i32) { // comparison in uint64, exact because ==
return 3;
} else if (x->u64 == i32) { // expected-warning {{comparison of integers of different signs}}
return 4;
} else {
return 5;
}
}
// PR5887
void test3() {
unsigned short x, y;
unsigned int z;
if ((x > y ? x : y) > z)
(void) 0;
}
// PR5961
extern char *ptr4;
void test4() {
long value;
if (value < (unsigned long) &ptr4) // expected-warning {{comparison of integers of different signs}}
return;
}
// PR4807
int test5(unsigned int x) {
return (x < 0) // expected-warning {{comparison of unsigned expression < 0 is always false}}
&& (0 > x) // expected-warning {{comparison of 0 > unsigned expression is always false}}
&& (x >= 0) // expected-warning {{comparison of unsigned expression >= 0 is always true}}
&& (0 <= x); // expected-warning {{comparison of 0 <= unsigned expression is always true}}
}
int test6(unsigned i, unsigned power) {
unsigned x = (i < (1 << power) ? i : 0);
return x != 3 ? 1 << power : i;
}
// <rdar://problem/8414119> enum >= (enum)0 comparison should not generate any warnings
enum rdar8414119_Vals { X, Y, Z };
#define ZERO 0
#define CHECK(x) (x >= X)
void rdar8414119_foo(enum rdar8414119_Vals v) {
if (CHECK(v)) // no-warning
return;
if (v >= X) // no-warning
return;
}
int rdar8414119_bar(unsigned x) {
return x >= ZERO; // no-warning
}
#undef ZERO
#undef CHECK
int rdar8511238() {
enum A { A_foo, A_bar };
enum A a;
if (a == 0)
return 0;
if (a != 0)
return 0;
if (a < 0) // expected-warning {{comparison of unsigned enum expression < 0 is always false}}
return 0;
if (a <= 0)
return 0;
if (a > 0)
return 0;
if (a >= 0) // expected-warning {{comparison of unsigned enum expression >= 0 is always true}}
return 0;
if (0 == a)
return 0;
if (0 != a)
return 0;
if (0 < a)
return 0;
if (0 <= a) // expected-warning {{comparison of 0 <= unsigned enum expression is always true}}
return 0;
if (0 > a) // expected-warning {{comparison of 0 > unsigned enum expression is always false}}
return 0;
if (0 >= a)
return 0;
if (a == 0U)
return 0;
if (a != 0U)
return 0;
if (a < 0U) // expected-warning {{comparison of unsigned enum expression < 0 is always false}}
return 0;
if (a <= 0U)
return 0;
if (a > 0U)
return 0;
if (a >= 0U) // expected-warning {{comparison of unsigned enum expression >= 0 is always true}}
return 0;
if (0U == a)
return 0;
if (0U != a)
return 0;
if (0U < a)
return 0;
if (0U <= a) // expected-warning {{comparison of 0 <= unsigned enum expression is always true}}
return 0;
if (0U > a) // expected-warning {{comparison of 0 > unsigned enum expression is always false}}
return 0;
if (0U >= a)
return 0;
return 20;
}
// PR10336
int test9(int sv, unsigned uv, long slv) {
return sv == (uv ^= slv); // expected-warning {{comparison of integers of different signs: 'int' and 'unsigned int'}}
}
void test10(void) {
int si;
unsigned int ui;
long sl;
_Bool b;
b = (si == (ui = sl)); // expected-warning {{comparison of integers of different signs: 'int' and 'unsigned int'}}
b = (si == (ui = sl&15));
}
// PR11572
struct test11S { unsigned x : 30; };
int test11(unsigned y, struct test11S *p) {
return y > (p->x >> 24); // no-warning
}
typedef char one_char[1];
typedef char two_chars[2];
void test12(unsigned a) {
if (0 && -1 > a) { }
}
// PR36008
enum PR36008EnumTest {
kPR36008Value = 0,
};
void pr36008(enum PR36008EnumTest lhs) {
__typeof__(lhs) x = lhs;
__typeof__(kPR36008Value) y = (kPR36008Value);
if (x == y) x = y; // no warning
if (y == x) y = x; // no warning
}
|
