aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Lohnau <alexander.lohnau@gmx.de>2024-01-26 18:00:18 +0100
committerAlexander Lohnau <alexander.lohnau@gmx.de>2024-01-29 18:33:17 +0000
commit4c085c036874be124521a2c4aff60a1140020a1f (patch)
treecec280cf6f07f0c1fe10969769615ab099aba1f7
parentd41f8150885727da4a3363eb6bb4e3cbe5cde969 (diff)
empty-qstringliteral: Be more precise about non-null string creation, mention QString() possibility
In case the developer is not sure which one is appropriate, they should consult the readme for the check
-rw-r--r--src/checks/level0/empty-qstringliteral.cpp4
-rw-r--r--tests/empty-qstringliteral/main.cpp.expected6
2 files changed, 5 insertions, 5 deletions
diff --git a/src/checks/level0/empty-qstringliteral.cpp b/src/checks/level0/empty-qstringliteral.cpp
index e2ab6f1b..8dfc9244 100644
--- a/src/checks/level0/empty-qstringliteral.cpp
+++ b/src/checks/level0/empty-qstringliteral.cpp
@@ -56,7 +56,7 @@ void EmptyQStringliteral::handleQt6StringLiteral(clang::Stmt *stmt)
if (auto c = dyn_cast<CallExpr>(stmt)) {
if (clazy::qualifiedMethodName(c->getDirectCallee()) == "QtPrivate::qMakeStringPrivate") {
if (auto lt = clazy::getFirstChildOfType<StringLiteral>(c); lt && lt->getByteLength() == 0) {
- emitWarning(stmt, "Use an empty QLatin1String instead of an empty QStringLiteral");
+ emitWarning(stmt, "Use QLatin1String(\"\") or QString() instead of an empty QStringLiteral");
}
}
}
@@ -86,5 +86,5 @@ void EmptyQStringliteral::handleQt5StringLiteral(clang::Stmt *stmt)
return;
}
- emitWarning(stmt, "Use an empty QLatin1String instead of an empty QStringLiteral");
+ emitWarning(stmt, "Use QLatin1String(\"\") or QString() instead of an empty QStringLiteral");
}
diff --git a/tests/empty-qstringliteral/main.cpp.expected b/tests/empty-qstringliteral/main.cpp.expected
index b98d1827..6fed19af 100644
--- a/tests/empty-qstringliteral/main.cpp.expected
+++ b/tests/empty-qstringliteral/main.cpp.expected
@@ -1,3 +1,3 @@
-empty-qstringliteral/main.cpp:7:5: warning: Use an empty QLatin1String instead of an empty QStringLiteral [-Wclazy-empty-qstringliteral]
-empty-qstringliteral/main.cpp:8:5: warning: Use an empty QLatin1String instead of an empty QStringLiteral [-Wclazy-empty-qstringliteral]
-empty-qstringliteral/main.cpp:10:18: warning: Use an empty QLatin1String instead of an empty QStringLiteral [-Wclazy-empty-qstringliteral]
+empty-qstringliteral/main.cpp:7:5: warning: Use QLatin1String("") or QString() instead of an empty QStringLiteral [-Wclazy-empty-qstringliteral]
+empty-qstringliteral/main.cpp:8:5: warning: Use QLatin1String("") or QString() instead of an empty QStringLiteral [-Wclazy-empty-qstringliteral]
+empty-qstringliteral/main.cpp:10:18: warning: Use QLatin1String("") or QString() instead of an empty QStringLiteral [-Wclazy-empty-qstringliteral]