diff options
author | Sergio Martins <iamsergio@gmail.com> | 2018-12-03 11:30:49 +0000 |
---|---|---|
committer | Sergio Martins <iamsergio@gmail.com> | 2018-12-03 11:30:49 +0000 |
commit | 8dc3294379f0a2a95fc49573512ee1514bae13d7 (patch) | |
tree | 3126aceae786f59b9f1ae6f87be527490da236fe /docs/checks | |
parent | 9713a15f65424f06e45c78fc1bf1c2d2b27f4e36 (diff) |
Revert "inefficient-qlist: Use 64 as the limit, instead of sizeof(void*)"
This reverts commit 9713a15f65424f06e45c78fc1bf1c2d2b27f4e36.
This doesn't make sense, I mixed up the logic.
CCBUG: 401494
Diffstat (limited to 'docs/checks')
-rw-r--r-- | docs/checks/README-inefficient-qlist-soft.md | 2 | ||||
-rw-r--r-- | docs/checks/README-inefficient-qlist.md | 5 |
2 files changed, 2 insertions, 5 deletions
diff --git a/docs/checks/README-inefficient-qlist-soft.md b/docs/checks/README-inefficient-qlist-soft.md index 1795c3a7..beebb3d1 100644 --- a/docs/checks/README-inefficient-qlist-soft.md +++ b/docs/checks/README-inefficient-qlist-soft.md @@ -2,6 +2,6 @@ A less aggressive version of the **inefficient-qlist** check. -Finds `QList<T>` where `sizeof(T) > 64`. `QVector<T>` should be used instead. +Finds `QList<T>` where `sizeof(T) > sizeof(void*)`. `QVector<T>` should be used instead. Only warns if the container is a local variable and isn't passed to any method or returned, unlike **inefficient-qlist**. This makes it easier to fix the warnings without concern about source and binary compatibility. diff --git a/docs/checks/README-inefficient-qlist.md b/docs/checks/README-inefficient-qlist.md index fc7dbf76..3bfe3f1c 100644 --- a/docs/checks/README-inefficient-qlist.md +++ b/docs/checks/README-inefficient-qlist.md @@ -1,8 +1,5 @@ # inefficient-qlist -Finds `QList<T>` where `sizeof(T) > 64`. `QVector<T>` should be used instead. - -This check uses 64 as the limit instead of `sizeof(void*)` so that it gives the same -results in 32-bit platforms. Making your 32-bit code portable to 64-bit without pessimizations. +Finds `QList<T>` where `sizeof(T) > sizeof(void*)`. `QVector<T>` should be used instead. This is a very noisy check and hence disabled by default. See **inefficient-qlist-soft** for a more useful check. |