aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSergio Martins <smartins@kde.org>2019-05-09 19:48:17 +0100
committerSergio Martins <smartins@kde.org>2019-05-09 20:10:11 +0100
commit52c35819162bd23b3b4e406784fa5cbc17cedfcc (patch)
treeb871c5e839816090f6412d0d3944ff7adda16baa /src
parent948a23ae1b1553cf67dc8b523236cc0e7dc74994 (diff)
qvariant-template-instantiation: Move out of level 0, since it has false-positives
This check has really been noise since its creation. The rate of false-positives don't justify the insignificant compilation performance gains. Moved to manual level now. Currently it has a bug, which doesn't seem possible to solve, as the instantiated template doesn't carry over the information about the qint32 typedef. And the CallExpr doesn't have any template related getters. Also removed this check from the "performance" category in checks.json, since this category is for runtime performance. CCBUG: 407321
Diffstat (limited to 'src')
-rw-r--r--src/Checks.h4
-rw-r--r--src/checks/manuallevel/qvariant-template-instantiation.cpp (renamed from src/checks/level0/qvariant-template-instantiation.cpp)0
-rw-r--r--src/checks/manuallevel/qvariant-template-instantiation.h (renamed from src/checks/level0/qvariant-template-instantiation.h)0
3 files changed, 2 insertions, 2 deletions
diff --git a/src/Checks.h b/src/Checks.h
index 709d66cb..1bb85ee5 100644
--- a/src/Checks.h
+++ b/src/Checks.h
@@ -38,6 +38,7 @@
#include "checks/manuallevel/qstring-varargs.h"
#include "checks/manuallevel/qt-keywords.h"
#include "checks/manuallevel/qt4-qstring-from-array.h"
+#include "checks/manuallevel/qvariant-template-instantiation.h"
#include "checks/manuallevel/raw-environment-function.h"
#include "checks/manuallevel/reserve-candidates.h"
#include "checks/manuallevel/thread-with-slots.h"
@@ -63,7 +64,6 @@
#include "checks/level0/qstring-insensitive-allocation.h"
#include "checks/level0/qstring-ref.h"
#include "checks/level0/qt-macros.h"
-#include "checks/level0/qvariant-template-instantiation.h"
#include "checks/level0/strict-iterators.h"
#include "checks/level0/temporary-iterator.h"
#include "checks/level0/unused-non-trivial-variable.h"
@@ -130,6 +130,7 @@ void CheckManager::registerChecks()
registerFixIt(1, "fix-qt-keywords", "qt-keywords");
registerCheck(check<Qt4QStringFromArray>("qt4-qstring-from-array", ManualCheckLevel, RegisteredCheck::Option_VisitsStmts));
registerFixIt(1, "fix-qt4-qstring-from-array", "qt4-qstring-from-array");
+ registerCheck(check<QVariantTemplateInstantiation>("qvariant-template-instantiation", ManualCheckLevel, RegisteredCheck::Option_VisitsStmts));
registerCheck(check<RawEnvironmentFunction>("raw-environment-function", ManualCheckLevel, RegisteredCheck::Option_VisitsStmts));
registerCheck(check<ReserveCandidates>("reserve-candidates", ManualCheckLevel, RegisteredCheck::Option_VisitsStmts));
registerCheck(check<ThreadWithSlots>("thread-with-slots", ManualCheckLevel, RegisteredCheck::Option_VisitsStmts | RegisteredCheck::Option_VisitsDecls));
@@ -160,7 +161,6 @@ void CheckManager::registerChecks()
registerCheck(check<StringRefCandidates>("qstring-ref", CheckLevel0, RegisteredCheck::Option_VisitsStmts));
registerFixIt(1, "fix-missing-qstringref", "qstring-ref");
registerCheck(check<QtMacros>("qt-macros", CheckLevel0, RegisteredCheck::Option_None));
- registerCheck(check<QVariantTemplateInstantiation>("qvariant-template-instantiation", CheckLevel0, RegisteredCheck::Option_VisitsStmts));
registerCheck(check<StrictIterators>("strict-iterators", CheckLevel0, RegisteredCheck::Option_VisitsStmts));
registerCheck(check<TemporaryIterator>("temporary-iterator", CheckLevel0, RegisteredCheck::Option_VisitsStmts));
registerCheck(check<UnusedNonTrivialVariable>("unused-non-trivial-variable", CheckLevel0, RegisteredCheck::Option_VisitsStmts));
diff --git a/src/checks/level0/qvariant-template-instantiation.cpp b/src/checks/manuallevel/qvariant-template-instantiation.cpp
index 170d1e50..170d1e50 100644
--- a/src/checks/level0/qvariant-template-instantiation.cpp
+++ b/src/checks/manuallevel/qvariant-template-instantiation.cpp
diff --git a/src/checks/level0/qvariant-template-instantiation.h b/src/checks/manuallevel/qvariant-template-instantiation.h
index 9059ea79..9059ea79 100644
--- a/src/checks/level0/qvariant-template-instantiation.h
+++ b/src/checks/manuallevel/qvariant-template-instantiation.h