aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSergio Martins <smartins@kde.org>2019-09-30 22:25:03 +0100
committerSergio Martins <smartins@kde.org>2019-09-30 22:25:03 +0100
commit76168b30dea7cc5d8d63e03f2a46e14ca9eb30ac (patch)
treeaf241d49cec87c246c8462ace2758add4c59e2cd /src
parentfe237dd5b035ae6509da31268f9e255127a6558a (diff)
qproperty-type-mismatch: comment-out warnings about "too many arguments"
These don't indicate bugs and are common place. We can maybe wrap them with an option to enable them.
Diffstat (limited to 'src')
-rw-r--r--src/checks/manuallevel/qproperty-type-mismatch.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/checks/manuallevel/qproperty-type-mismatch.cpp b/src/checks/manuallevel/qproperty-type-mismatch.cpp
index 1e45804a..889922e9 100644
--- a/src/checks/manuallevel/qproperty-type-mismatch.cpp
+++ b/src/checks/manuallevel/qproperty-type-mismatch.cpp
@@ -147,7 +147,8 @@ void QPropertyTypeMismatch::checkMethodAgainstProperty (const Property& prop, co
break;
}
default:
- emitWarning(&method, error_begin() + "method '" + methodName + "' with too many parameters");
+ // Commented out: Too verbose and it's not a bug, maybe wrap with an option for the purists
+ // emitWarning(&method, error_begin() + "method '" + methodName + "' with too many parameters");
break;
}
}
@@ -159,6 +160,8 @@ void QPropertyTypeMismatch::checkMethodAgainstProperty (const Property& prop, co
break;
case 2:
{
+ /*
+ // Commented out: Too verbose and it's not a bug, maybe wrap with an option for the purists
auto param1TypeStr = cleanupType(method.getParamDecl(1)->getType());
if(param1TypeStr.find("QPrivateSignal") == std::string::npos)
{
@@ -167,7 +170,7 @@ void QPropertyTypeMismatch::checkMethodAgainstProperty (const Property& prop, co
}
// We want to check the first parameter too :
- [[fallthrough]];
+ [[fallthrough]];*/
}
case 1:
{