range-loop: Fix some true-negatives that didn't suggest qAsConst()

This now warns:
   QStringList list = getList();
   for (const QString &s : list)

CCMAIL: dfaure@kde.org

1 files changed, 14 insertions, 1 deletions

diff --git a/src/QtUtils.cpp b/src/QtUtils.cpp
index 4bc61e6b..0d66bb1b 100644
--- a/src/QtUtils.cpp
+++ b/src/QtUtils.cpp
@@ -207,10 +207,12 @@ bool clazy::isQtContainer(const CXXRecordDecl *record)
 
 bool clazy::containerNeverDetaches(const clang::VarDecl *valDecl, StmtBodyRange bodyRange) // clazy:exclude=function-args-by-value
 {
+    // This helps for bug 367485
+
     if (!valDecl)
         return false;
 
-    const FunctionDecl *context = dyn_cast<FunctionDecl>(valDecl->getDeclContext());
+    const auto context = dyn_cast<FunctionDecl>(valDecl->getDeclContext());
     if (!context)
         return false;
 
@@ -218,6 +220,17 @@ bool clazy::containerNeverDetaches(const clang::VarDecl *valDecl, StmtBodyRange
     if (!bodyRange.body)
         return false;
 
+    if (valDecl->hasInit()) {
+        if (auto cleanupExpr = dyn_cast<clang::ExprWithCleanups>(valDecl->getInit())) {
+            if (auto ce = dyn_cast<clang::CXXConstructExpr>(cleanupExpr->getSubExpr())) {
+                if (!ce->isListInitialization() && !ce->isStdInitListInitialization()) {
+                    // When initing via copy or move ctor there's possible detachments.
+                    return false;
+                }
+            }
+        }
+    }
+
     // TODO1: Being passed to a function as const should be OK
     if (Utils::isPassedToFunction(bodyRange, valDecl, false))
         return false;