aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSergio Martins <smartins@kde.org>2019-09-29 20:30:21 +0100
committerSergio Martins <smartins@kde.org>2019-09-29 20:30:21 +0100
commitb90dc89695350b2f0eb2872b414cb44f0c1b1671 (patch)
tree0d431a024c010258f96f08e42b48b7239f7ae380 /src
parent1edd1c50b6b6c03edb5c2f8e3d16596353a025c8 (diff)
qproperty-type-mismatch: Dont' warn about signal having 0 args
It's common place for the NOTIFY signal to not have arguments, and there's no performance improvement on not adding one
Diffstat (limited to 'src')
-rw-r--r--src/checks/manuallevel/qproperty-type-mismatch.cpp4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/checks/manuallevel/qproperty-type-mismatch.cpp b/src/checks/manuallevel/qproperty-type-mismatch.cpp
index 75788fcf..a0e29002 100644
--- a/src/checks/manuallevel/qproperty-type-mismatch.cpp
+++ b/src/checks/manuallevel/qproperty-type-mismatch.cpp
@@ -148,10 +148,6 @@ void QPropertyTypeMismatch::checkMethodAgainstProperty (const Property& prop, co
switch(method.getNumParams())
{
case 0:
- // Should this case be ok ?
- // I don't think it is good practice to have signals of a property without
- // the property value in parameter, but afaik it's valid in Qt.
- emitWarning(&method, "Q_PROPERTY '" + prop.name + "' of type '" + prop.type + "' is mismatched with signal '" + methodName + "' with no parameters");
break;
case 2:
{