aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSergio Martins <smartins@kde.org>2017-10-15 22:02:06 +0100
committerSergio Martins <iamsergio@gmail.com>2017-10-15 22:03:34 +0100
commit7312067975d0ad74f04960f1f7c46f35b9ce6d13 (patch)
treef39ee2b191d463c6ed50b8a154faa4dafca8b9fb /src
parentaf6881a27053162510177e881d8d023eefdc0a62 (diff)
detaching-temporary: Don't warn for intersect, unite and subtract
These are fine to be called on a temporary, since they return a reference to the object itself, which then must be stored or something done with it due to Q_REQUIRED_RESULT
Diffstat (limited to 'src')
-rw-r--r--src/checks/level1/detachingtemporary.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/checks/level1/detachingtemporary.cpp b/src/checks/level1/detachingtemporary.cpp
index 7f0e0ee3..5dea61de 100644
--- a/src/checks/level1/detachingtemporary.cpp
+++ b/src/checks/level1/detachingtemporary.cpp
@@ -42,12 +42,12 @@ DetachingTemporary::DetachingTemporary(const std::string &name, ClazyContext *co
m_writeMethodsByType["QString"] = {"push_back", "push_front", "clear", "chop"};
m_writeMethodsByType["QList"] = {"takeAt", "takeFirst", "takeLast", "removeOne", "removeAll", "erase"};
m_writeMethodsByType["QVector"] = { "fill", "insert"};
- m_writeMethodsByType["QMap"] = { "erase", "insert", "insertMulti", "remove", "take", "unite" };
- m_writeMethodsByType["QHash"] = { "erase", "insert", "insertMulti", "remove", "take", "unite"};
+ m_writeMethodsByType["QMap"] = { "erase", "insert", "insertMulti", "remove", "take"};
+ m_writeMethodsByType["QHash"] = { "erase", "insert", "insertMulti", "remove", "take"};
m_writeMethodsByType["QMultiHash"] = m_writeMethodsByType["QHash"];
m_writeMethodsByType["QMultiMap"] = m_writeMethodsByType["QMap"];
m_writeMethodsByType["QLinkedList"] = {"takeFirst", "takeLast", "removeOne", "removeAll", "erase"};
- m_writeMethodsByType["QSet"] = {"erase", "insert", "intersect", "unite", "subtract"};
+ m_writeMethodsByType["QSet"] = {"erase", "insert"};
m_writeMethodsByType["QStack"] = {"push", "swap"};
m_writeMethodsByType["QQueue"] = {"enqueue", "swap"};
m_writeMethodsByType["QListSpecialMethods"] = {"sort", "replaceInStrings", "removeDuplicates"};