Warn when using QObject::tr() with non literals.

Example: tr(myStr.toUtf8())

Suggested by Volker Krause

1 files changed, 8 insertions, 7 deletions

diff --git a/tests/clazy/test_requested_checks.sh.expected b/tests/clazy/test_requested_checks.sh.expected
index c9a34614..4e85ae36 100644
--- a/tests/clazy/test_requested_checks.sh.expected
+++ b/tests/clazy/test_requested_checks.sh.expected
@@ -1,6 +1,6 @@
-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
+Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, tr-non-literal, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Invalid check: foo
-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
+Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, tr-non-literal, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: foreach
 Requested checks: foreach, writing-to-temporary
 Invalid check: foo
@@ -8,16 +8,16 @@ Requested checks: foreach, writing-to-temporary
 Requested checks: old-style-connect
 Requested checks: old-style-connect
 Requested checks: foreach, old-style-connect
-Requested checks: auto-unexpected-qstringbuilder, base-class-event, child-event-qobject-cast, connect-non-signal, container-anti-pattern, container-inside-loop, copyable-polymorphic, ctor-missing-parent-argument, detaching-temporary, foreach, function-args-by-ref, function-args-by-value, global-const-char-pointer, implicit-casts, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, missing-typeinfo, mutable-container-key, non-pod-global-static, old-style-connect, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-allocations, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, reserve-candidates, returning-data-from-temporary, returning-void-expression, rule-of-three, rule-of-two-soft, temporary-iterator, unused-non-trivial-variable, virtual-call-ctor, writing-to-temporary, wrong-qglobalstatic
+Requested checks: auto-unexpected-qstringbuilder, base-class-event, child-event-qobject-cast, connect-non-signal, container-anti-pattern, container-inside-loop, copyable-polymorphic, ctor-missing-parent-argument, detaching-temporary, foreach, function-args-by-ref, function-args-by-value, global-const-char-pointer, implicit-casts, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, missing-typeinfo, mutable-container-key, non-pod-global-static, old-style-connect, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-allocations, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, reserve-candidates, returning-data-from-temporary, returning-void-expression, rule-of-three, rule-of-two-soft, temporary-iterator, tr-non-literal, unused-non-trivial-variable, virtual-call-ctor, writing-to-temporary, wrong-qglobalstatic
 Requested checks: implicit-casts
 Requested checks: foreach, implicit-casts
 Requested checks: old-style-connect
 Requested checks: connect-non-signal, container-anti-pattern, lambda-in-connect, mutable-container-key, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
+Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, tr-non-literal, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: connect-non-signal, container-anti-pattern, lambda-in-connect, mutable-container-key, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, reserve-candidates, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: connect-non-signal, container-anti-pattern, lambda-in-connect, mutable-container-key, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: connect-non-signal, container-anti-pattern, foreach, implicit-casts, lambda-in-connect, mutable-container-key, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
+Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, tr-non-literal, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: connect-non-signal, container-anti-pattern, lambda-in-connect, mutable-container-key, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, reserve-candidates, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: connect-non-signal, container-anti-pattern, implicit-casts, lambda-in-connect, mutable-container-key, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, reserve-candidates, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: implicit-casts
@@ -61,6 +61,7 @@ Checks from level1:
     range-loop
     returning-data-from-temporary
     rule-of-two-soft
+    tr-non-literal
 
 Checks from level2:
     base-class-event
@@ -103,6 +104,6 @@ Backup your code before running them.
 Requested checks: connect-non-signal, container-anti-pattern, lambda-in-connect, mutable-container-key, qdatetime-utc, qfileinfo-exists, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: implicit-casts
 Requested checks: implicit-casts
-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
+Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, tr-non-literal, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
 Requested checks: connect-non-signal, container-anti-pattern, lambda-in-connect, mutable-container-key, qdatetime-utc, qfileinfo-exists, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic
+Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-non-signal, container-anti-pattern, detaching-temporary, foreach, incorrect-emit, inefficient-qlist-soft, lambda-in-connect, missing-qobject-macro, mutable-container-key, non-pod-global-static, post-event, qdatetime-utc, qdeleteall, qfileinfo-exists, qgetenv, qlatin1string-non-ascii, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, temporary-iterator, tr-non-literal, unused-non-trivial-variable, writing-to-temporary, wrong-qglobalstatic