detaching-member: Fix a bunch of false-positives

such as:

a[0] = "foo"; These kind of detachments are fine and unavoidable

BUG: 354124

2 files changed, 12 insertions, 0 deletions

diff --git a/tests/detaching-member/main.cpp b/tests/detaching-member/main.cpp
index b9ad45be..eae41ece 100644
--- a/tests/detaching-member/main.cpp
+++ b/tests/detaching-member/main.cpp
@@ -29,7 +29,18 @@ struct A
         m_mutableString[0]; // Warning
     }
 
+    void testAssignment()
+    {
+        m_string[0] = QChar('a'); // OK
+        m_mutableString[0] = QChar('a'); // OK
+        m_list[0]++;    // OK
+        m_list[0] += 2; // OK
+        m_list2[0] = m_list[0]; // Warning
+    }
+
+
     QList<int> m_list;
+    QList<int> m_list2;
     QString m_string;
     mutable QString m_mutableString;
     const QList<int> m_constList;
diff --git a/tests/detaching-member/test.expected b/tests/detaching-member/test.expected
index 2d5f94ea..3f080361 100644
--- a/tests/detaching-member/test.expected
+++ b/tests/detaching-member/test.expected
@@ -2,3 +2,4 @@ main.cpp:7:9: warning: Potential detachment due to calling QList<int>::begin() [
 main.cpp:17:9: warning: Potential detachment due to calling QList<int>::begin() [-Wclazy-detaching-member]
 main.cpp:28:9: warning: Potential detachment due to calling QString::begin() [-Wclazy-detaching-member]
 main.cpp:29:9: warning: Potential detachment due to calling QString::operator[]() [-Wclazy-detaching-member]
+main.cpp:38:22: warning: Potential detachment due to calling QList<int>::operator[]() [-Wclazy-detaching-member]