diff options
author | Sergio Martins <smartins@kde.org> | 2016-12-19 11:55:25 +0000 |
---|---|---|
committer | Sergio Martins <smartins@kde.org> | 2016-12-19 11:55:25 +0000 |
commit | 09e86a3ce2f8df305aad87d8dabc483dc211f05e (patch) | |
tree | 0562e1aa4bdb3c2e88ff17dbd7483f23f252c9ed /tests/incorrect-emit | |
parent | 6372192722dad58cbcf4cb50e9e299654f45dab7 (diff) |
incorrect-emit: Warn when emitting signal inside CTOR
it cna't be caught
Diffstat (limited to 'tests/incorrect-emit')
-rw-r--r-- | tests/incorrect-emit/main.cpp | 10 | ||||
-rw-r--r-- | tests/incorrect-emit/main.cpp.expected | 7 |
2 files changed, 13 insertions, 4 deletions
diff --git a/tests/incorrect-emit/main.cpp b/tests/incorrect-emit/main.cpp index 0a804596..4335623c 100644 --- a/tests/incorrect-emit/main.cpp +++ b/tests/incorrect-emit/main.cpp @@ -12,10 +12,10 @@ static MyObject * s_obj; class MyObject : public QObject { public: + MyObject(); void pub(); MyObject* memberFunc() const; MyObject *another; - private: void priv(); @@ -48,3 +48,11 @@ void MyObject::pub() emit another->sig(); // OK emit s_obj->sig(); // OK } + + +MyObject::MyObject() +{ + emit sig(); // Warning + emit another->sig(); // OK; + emit memberFunc()->sig(); // OK; +} diff --git a/tests/incorrect-emit/main.cpp.expected b/tests/incorrect-emit/main.cpp.expected index 1b3f0660..7d6dbdc1 100644 --- a/tests/incorrect-emit/main.cpp.expected +++ b/tests/incorrect-emit/main.cpp.expected @@ -1,5 +1,6 @@ incorrect-emit/main.cpp:37:11: warning: Emit keyword being used with non-signal MyObject::prot [-Wclazy-incorrect-emit] -incorrect-emit/main.cpp:38:5: warning: Missing emit keyword on signal call MyObject::sig; main.cpp [-Wclazy-incorrect-emit] +incorrect-emit/main.cpp:38:5: warning: Missing emit keyword on signal call MyObject::sig [-Wclazy-incorrect-emit] incorrect-emit/main.cpp:43:12: warning: Emit keyword being used with non-signal MyObject::privSlot [-Wclazy-incorrect-emit] -incorrect-emit/main.cpp:45:5: warning: Missing emit keyword on signal call MyObject::sig; main.cpp [-Wclazy-incorrect-emit] -incorrect-emit/main.cpp:47:5: warning: Missing emit keyword on signal call MyObject::sig; main.cpp [-Wclazy-incorrect-emit] +incorrect-emit/main.cpp:45:5: warning: Missing emit keyword on signal call MyObject::sig [-Wclazy-incorrect-emit] +incorrect-emit/main.cpp:47:5: warning: Missing emit keyword on signal call MyObject::sig [-Wclazy-incorrect-emit] +incorrect-emit/main.cpp:55:10: warning: Emitting inside constructor has no effect [-Wclazy-incorrect-emit] |