aboutsummaryrefslogtreecommitdiffstats
path: root/tests/qstring-arg
diff options
context:
space:
mode:
authorSergio Martins <smartins@kde.org>2015-10-13 19:22:38 +0100
committerSergio Martins <smartins@kde.org>2015-10-13 19:31:42 +0100
commited98b29bd09f20e45389f8c50f1f23e91e1d3ed1 (patch)
treeab77e74b07b71b28b7cc3b5b778ee75659cf55af /tests/qstring-arg
parenta6cbda791532685d3205d0fa52ab4dc7fe748228 (diff)
qstring-arg: Warn when using chainged args()
Using multi-arg overloads saves heap allocations BUG: 353771
Diffstat (limited to 'tests/qstring-arg')
-rw-r--r--tests/qstring-arg/main.cpp4
-rw-r--r--tests/qstring-arg/test.expected2
2 files changed, 6 insertions, 0 deletions
diff --git a/tests/qstring-arg/main.cpp b/tests/qstring-arg/main.cpp
index 867a3b90..7dd92048 100644
--- a/tests/qstring-arg/main.cpp
+++ b/tests/qstring-arg/main.cpp
@@ -23,4 +23,8 @@ void test()
s = s.arg(1, m_labelFieldWidth); // OK
s = s.arg(1, latitude); // Warning
QString("%1").arg(s, -38); // OK
+ QString s2, s3, s4, s5;
+ s5 = QString("%1 %2 %3 %4").arg(s).arg(s1).arg(s3, s4); // Warning
+ QString().arg(s1, s2, s3, s4, s5).arg(s1, s2, s3, s4, s5); // OK
+ QString().arg(s1, s2, s3, s4, s5).arg(s1, s2, s3, s4); // Warning
}
diff --git a/tests/qstring-arg/test.expected b/tests/qstring-arg/test.expected
index 31e36a5b..99c35a56 100644
--- a/tests/qstring-arg/test.expected
+++ b/tests/qstring-arg/test.expected
@@ -1,3 +1,5 @@
main.cpp:19:9: warning: Using QString::arg() with fillChar overload [-Wclazy-qstring-arg]
main.cpp:20:9: warning: Using QString::arg() with fillChar overload [-Wclazy-qstring-arg]
main.cpp:24:9: warning: Using QString::arg() with fillChar overload [-Wclazy-qstring-arg]
+main.cpp:27:46: warning: Use multi-arg instead [-Wclazy-qstring-arg]
+main.cpp:29:37: warning: Use multi-arg instead [-Wclazy-qstring-arg]