aboutsummaryrefslogtreecommitdiffstats
path: root/src/checks/level0/connect-by-name.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'src/checks/level0/connect-by-name.cpp')
-rw-r--r--src/checks/level0/connect-by-name.cpp64
1 files changed, 64 insertions, 0 deletions
diff --git a/src/checks/level0/connect-by-name.cpp b/src/checks/level0/connect-by-name.cpp
new file mode 100644
index 00000000..e830d823
--- /dev/null
+++ b/src/checks/level0/connect-by-name.cpp
@@ -0,0 +1,64 @@
+/*
+ This file is part of the clazy static checker.
+
+ Copyright (C) 2017 Sergio Martins <smartins@kde.org>
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Library General Public
+ License as published by the Free Software Foundation; either
+ version 2 of the License, or (at your option) any later version.
+
+ This library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Library General Public License for more details.
+
+ You should have received a copy of the GNU Library General Public License
+ along with this library; see the file COPYING.LIB. If not, write to
+ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ Boston, MA 02110-1301, USA.
+*/
+
+#include "connect-by-name.h"
+#include "Utils.h"
+#include "HierarchyUtils.h"
+#include "QtUtils.h"
+#include "TypeUtils.h"
+#include "ClazyContext.h"
+#include "AccessSpecifierManager.h"
+
+#include <clang/AST/AST.h>
+
+using namespace clang;
+using namespace std;
+
+
+ConnectByName::ConnectByName(const std::string &name, ClazyContext *context)
+ : CheckBase(name, context)
+{
+ context->enableAccessSpecifierManager();
+}
+
+void ConnectByName::VisitDecl(clang::Decl *decl)
+{
+ auto record = dyn_cast<CXXRecordDecl>(decl);
+ if (!record)
+ return;
+
+ AccessSpecifierManager *accessSpecifierManager = m_context->accessSpecifierManager;
+ if (!accessSpecifierManager)
+ return;
+
+ for (auto method : record->methods()) {
+ std::string name = method->getNameAsString();
+ if (clazy::startsWith(name, "on_")) {
+ QtAccessSpecifierType qst = accessSpecifierManager->qtAccessSpecifierType(method);
+ if (qst == QtAccessSpecifier_Slot) {
+ auto tokens = clazy::splitString(name, '_');
+ if (tokens.size() == 3) {
+ emitWarning(method, "Slots named on_foo_bar are error prone");
+ }
+ }
+ }
+ }
+}