1 files changed, 83 insertions, 0 deletions
diff --git a/src/checks/level1/auto-unexpected-qstringbuilder.cpp b/src/checks/level1/auto-unexpected-qstringbuilder.cpp
new file mode 100644
index 00000000..01ae42bf
--- /dev/null
+++ b/src/checks/level1/auto-unexpected-qstringbuilder.cpp
@@ -0,0 +1,83 @@
+/*
+   This file is part of the clazy static checker.
+
+  Copyright (C) 2015 Sergio Martins <smartins@kde.org>
+  Copyright (C) 2015 Mathias Hasselmann <mathias.hasselmann@kdab.com>
+
+  This library is free software; you can redistribute it and/or
+  modify it under the terms of the GNU Library General Public
+  License as published by the Free Software Foundation; either
+  version 2 of the License, or (at your option) any later version.
+
+  This library is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  Library General Public License for more details.
+
+  You should have received a copy of the GNU Library General Public License
+  along with this library; see the file COPYING.LIB.  If not, write to
+  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+  Boston, MA 02110-1301, USA.
+*/
+
+#include "auto-unexpected-qstringbuilder.h"
+#include "Utils.h"
+#include "StringUtils.h"
+#include "FixItUtils.h"
+#include "TypeUtils.h"
+
+#include <clang/AST/AST.h>
+#include <clang/Lex/Lexer.h>
+
+using namespace clang;
+using namespace std;
+
+static bool isQStringBuilder(QualType t)
+{
+    CXXRecordDecl *record = TypeUtils::typeAsRecord(t);
+    return record && record->getName() == "QStringBuilder";
+}
+
+AutoUnexpectedQStringBuilder::AutoUnexpectedQStringBuilder(const std::string &name, ClazyContext *context)
+    : CheckBase(name, context, Option_CanIgnoreIncludes)
+{
+}
+
+void AutoUnexpectedQStringBuilder::VisitDecl(Decl *decl)
+{
+    VarDecl *varDecl = dyn_cast<VarDecl>(decl);
+    if (!varDecl)
+        return;
+
+    QualType qualtype = varDecl->getType();
+    const Type *type = qualtype.getTypePtrOrNull();
+    if (!type || !type->isRecordType() || !dyn_cast<AutoType>(type) || !isQStringBuilder(qualtype))
+        return;
+
+    std::vector<FixItHint> fixits;
+    if (isFixitEnabled()) {
+        std::string replacement = "QString " + varDecl->getName().str();
+
+        if (qualtype.isConstQualified())
+            replacement = "const " + replacement;
+
+        SourceLocation start = getLocStart(varDecl);
+        SourceLocation end = varDecl->getLocation();
+        fixits.push_back(clazy::createReplacement({ start, end }, replacement));
+    }
+
+    emitWarning(getLocStart(decl), "auto deduced to be QStringBuilder instead of QString. Possible crash.", fixits);
+}
+
+void AutoUnexpectedQStringBuilder::VisitStmt(Stmt *stmt)
+{
+    auto lambda = dyn_cast<LambdaExpr>(stmt);
+    if (!lambda)
+        return;
+
+    CXXMethodDecl *method = lambda->getCallOperator();
+    if (!method || !isQStringBuilder(method->getReturnType()))
+        return;
+
+    emitWarning(getLocStart(stmt), "lambda return type deduced to be QStringBuilder instead of QString. Possible crash.");
+}