1 files changed, 55 insertions, 0 deletions
diff --git a/src/checks/manuallevel/isempty-vs-count.cpp b/src/checks/manuallevel/isempty-vs-count.cpp
new file mode 100644
index 00000000..c1700780
--- /dev/null
+++ b/src/checks/manuallevel/isempty-vs-count.cpp
@@ -0,0 +1,55 @@
+/*
+   This file is part of the clazy static checker.
+
+  Copyright (C) 2015 Sergio Martins <smartins@kde.org>
+
+  This library is free software; you can redistribute it and/or
+  modify it under the terms of the GNU Library General Public
+  License as published by the Free Software Foundation; either
+  version 2 of the License, or (at your option) any later version.
+
+  This library is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  Library General Public License for more details.
+
+  You should have received a copy of the GNU Library General Public License
+  along with this library; see the file COPYING.LIB.  If not, write to
+  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+  Boston, MA 02110-1301, USA.
+*/
+
+#include "isempty-vs-count.h"
+#include "Utils.h"
+#include "StringUtils.h"
+#include "QtUtils.h"
+
+#include <clang/AST/AST.h>
+#include <clang/Lex/Lexer.h>
+
+using namespace clang;
+using namespace std;
+
+
+IsEmptyVSCount::IsEmptyVSCount(const std::string &name, ClazyContext *context)
+    : CheckBase(name, context, Option_CanIgnoreIncludes)
+{
+}
+
+void IsEmptyVSCount::VisitStmt(clang::Stmt *stmt)
+{
+    auto cast = dyn_cast<ImplicitCastExpr>(stmt);
+    if (!cast || cast->getCastKind() != clang::CK_IntegralToBoolean)
+        return;
+
+    auto memberCall = dyn_cast<CXXMemberCallExpr>(*(cast->child_begin()));
+    CXXMethodDecl *method = memberCall ? memberCall->getMethodDecl() : nullptr;
+
+    if (!clazy::functionIsOneOf(method, {"size", "count", "length"}))
+        return;
+
+    if (!clazy::classIsOneOf(method->getParent(), clazy::qtContainers()))
+        return;
+
+    emitWarning(getLocStart(stmt), "use isEmpty() instead");
+}