diff options
Diffstat (limited to 'src/checks/manuallevel/qt-keywords.cpp')
-rw-r--r-- | src/checks/manuallevel/qt-keywords.cpp | 74 |
1 files changed, 74 insertions, 0 deletions
diff --git a/src/checks/manuallevel/qt-keywords.cpp b/src/checks/manuallevel/qt-keywords.cpp new file mode 100644 index 00000000..1cd9085a --- /dev/null +++ b/src/checks/manuallevel/qt-keywords.cpp @@ -0,0 +1,74 @@ +/* + This file is part of the clazy static checker. + + Copyright (C) 2018 Sergio Martins <smartins@kde.org> + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Library General Public + License as published by the Free Software Foundation; either + version 2 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Library General Public License for more details. + + You should have received a copy of the GNU Library General Public License + along with this library; see the file COPYING.LIB. If not, write to + the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + Boston, MA 02110-1301, USA. +*/ + +#include "qt-keywords.h" +#include "Utils.h" +#include "HierarchyUtils.h" +#include "QtUtils.h" +#include "TypeUtils.h" +#include "FixItUtils.h" +#include "ClazyContext.h" +#include "PreProcessorVisitor.h" + +#include <clang/Lex/MacroInfo.h> +#include <clang/AST/AST.h> + +using namespace clang; +using namespace std; + +QtKeywords::QtKeywords(const std::string &name, ClazyContext *context) + : CheckBase(name, context) +{ + enablePreProcessorCallbacks(); + context->enablePreprocessorVisitor(); +} + +void QtKeywords::VisitMacroExpands(const Token ¯oNameTok, const SourceRange &range, const clang::MacroInfo *minfo) +{ + IdentifierInfo *ii = macroNameTok.getIdentifierInfo(); + if (!ii || !minfo) + return; + + if (auto ppvisitor = m_context->preprocessorVisitor) { + // Save some CPU cycles. No point in running if QT_NO_KEYWORDS + if (ppvisitor->isQT_NO_KEYWORDS()) + return; + } + + static const vector<StringRef> keywords = { "foreach", "signals", "slots", "emit" }; + std::string name = ii->getName(); + if (!clazy::contains(keywords, name)) + return; + + // Make sure the macro is Qt's. It must be defined in Qt's headers, not 3rdparty + std::string qtheader = sm().getFilename(sm().getSpellingLoc(minfo->getDefinitionLoc())); + if (!clazy::endsWith(qtheader, "qglobal.h") && !clazy::endsWith(qtheader, "qobjectdefs.h")) + return; + + std::vector<FixItHint> fixits; + if (isFixitEnabled()) { + std::string replacement = "Q_" + name; + std::transform(replacement.begin(), replacement.end(), replacement.begin(), ::toupper); + fixits.push_back(clazy::createReplacement(range, replacement)); + } + + emitWarning(range.getBegin(), "Using a Qt keyword (" + string(ii->getName()) + ")", fixits); +} |