From 64947baa482d9f043331a6fb1155e7ed117c0727 Mon Sep 17 00:00:00 2001 From: Alexander Lohnau Date: Sun, 4 Feb 2024 12:17:12 +0100 Subject: qgetenv: Limit scope to variables to if-statement if possible Otherwise, it is a bit confusing which variables are only relevant for throwaway-checks --- src/checks/level0/qgetenv.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/checks/level0/qgetenv.cpp b/src/checks/level0/qgetenv.cpp index 6c05434f..28afa7c2 100644 --- a/src/checks/level0/qgetenv.cpp +++ b/src/checks/level0/qgetenv.cpp @@ -49,8 +49,7 @@ void QGetEnv::VisitStmt(clang::Stmt *stmt) return; } - CXXRecordDecl *record = method->getParent(); - if (!record || clazy::name(record) != "QByteArray") { + if (CXXRecordDecl *record = method->getParent(); !record || clazy::name(record) != "QByteArray") { return; } @@ -60,10 +59,7 @@ void QGetEnv::VisitStmt(clang::Stmt *stmt) } CallExpr *qgetEnvCall = calls.back(); - - FunctionDecl *func = qgetEnvCall->getDirectCallee(); - - if (!func || clazy::name(func) != "qgetenv") { + if (FunctionDecl *func = qgetEnvCall->getDirectCallee(); !func || clazy::name(func) != "qgetenv") { return; } -- cgit v1.2.3